Create message-kind-specific parse methods and remove circular dependency #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rfq.parse()
which will ensure the payload is an RFQ message and can be easily extended to do RFQ-specific validationMessage.parse()
intoParser.parseMessage()
becauseMessage.parse()
causedMessage
to depend on its subclasses, which is a violation of OOP best practices and constitutes a circular dependency.