Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forcing resolution of io.netty:netty-codec-http version to be 4.1.108Final #228

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Forcing resolution of io.netty:netty-codec-http version to be 4.1.108Final #228

merged 1 commit into from
Apr 1, 2024

Conversation

jiyoontbd
Copy link
Contributor

@jiyoontbd jiyoontbd commented Apr 1, 2024 •
edited
Loading

@codecov-commenter
Copy link

Codecov Report

Merging #228 (201949f) into main (85598e1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files          38       38           
  Lines        1124     1124           
  Branches      114      114           
=======================================
  Hits          948      948           
  Misses        124      124           
  Partials       52       52
Components Coverage Δ
protocol 85.85% <ø> (ø)
httpclient 78.34% <ø> (ø)

@jiyoontbd jiyoontbd changed the title adding forceresolution for netty dep in ktor server Forcing resolution of io.netty:netty-codec-http version to be 4.1.108Final Apr 1, 2024
@jiyoontbd jiyoontbd marked this pull request as ready for review April 1, 2024 20:27
@jiyoontbd jiyoontbd merged commit 1079398 into main Apr 1, 2024
6 checks passed
@jiyoontbd jiyoontbd deleted the netty-vuln branch April 1, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistermoe mistermoe Awaiting requested review from mistermoe mistermoe is a code owner

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew phoebe-lew is a code owner

@michaelneale michaelneale Awaiting requested review from michaelneale michaelneale is a code owner

@KendallWeihe KendallWeihe Awaiting requested review from KendallWeihe KendallWeihe is a code owner

@ethan-tbd ethan-tbd Awaiting requested review from ethan-tbd ethan-tbd is a code owner

@tomdaffurn tomdaffurn Awaiting requested review from tomdaffurn tomdaffurn is a code owner

@diehuxx diehuxx Awaiting requested review from diehuxx diehuxx is a code owner

@kirahsapong kirahsapong Awaiting requested review from kirahsapong kirahsapong is a code owner

@nitro-neal nitro-neal Awaiting requested review from nitro-neal nitro-neal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiyoontbd @codecov-commenter