Consume web5-kt 1.1.0 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
mistermoe,
phoebe-lew,
jiyoonie9,
michaelneale,
KendallWeihe,
ethan-tbd,
tomdaffurn,
diehuxx and
kirahsapong
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage 84.28% 84.28%
=======================================
Files 38 38
Lines 1107 1107
Branches 115 115
=======================================
Hits 933 933
Misses 122 122
Partials 52 52
|
jiyoonie9
approved these changes
May 8, 2024
| @@ -17,7 +17,7 @@ | |||
| the version "version.xyz.block.web5" set this web5-parent. When updating Web5, update both | |||
| this version *and* the <version.xyz.block.web5> below in the <properties> section. | |||
| --> | |||
| <version>1.0.0</version> | |||
| <version>1.1.0</version> | |||
| </parent> | |||
There was a problem hiding this comment.
I don't think we need to update this version number ourselves? @ALRubinger
There was a problem hiding this comment.
Yes, if we're upgrading tbdex-kt to web5-kt:1.1.0, updating the version number in both places as this PR does is the right way.
Are the comments in the POM not describing that clearly enough? If not, let's update the comments!
diehuxx
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will consume web5-kt 1.0.0
This change has
credentialSchemafield in the vc data model