scaffold server with ktor as per issue #23 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelneale
requested review from
mistermoe,
phoebe-lew,
jiyoonie9,
KendallWeihe and
ethan-tbd
as code owners
phoebe-lew
approved these changes
Oct 4, 2023
ethan-tbd
approved these changes
Oct 4, 2023
|
is the outcome of this PR that i should be able to click "play" on the main function and have a server spun up? i couldn't get that to work. |
|
@jiyoontbd if you use 127.0.0.1:8080 then it will show "hello world" now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My hack take on: #23
still can't work out how to make intelliJ happy about it though - but lets try this.