#214 Restructure hosting of test vectors #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
michaelneale,
mistermoe,
jiyoonie9,
phoebe-lew and
KendallWeihe
as code owners
|
Instead of using this entire repo as a submodule in implementation repos (tbdex-js, tbdex-kt, etc.), let's pull the JSON schemas and test vectors into their own repo called tbdex-interop-suite, which is included as a submodule here and in implementation repos. |
This reverts commit c3e3327.
diehuxx
changed the title
|
Nice! A coupla thoughts...
|
As I was typing that out, I see you committed the files back. Sorry I may be throwing this for a loop. |
|
@KendallWeihe Sorry for the confusion! In a thread on Discord, we decided against puttin the vectors into a separate repo. So, I reverted to keeping the vectors in |
nitro-neal
reviewed
Jan 8, 2024
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "scripts": { | |||
| "validate-vectors": "node validate-vectors.js" | |||
nitro-neal
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate test vectors into one test vector per file. Set up a validation script to ensure all test vectors follow a common format.
See
hosted/test-vectors/protocol/README.mdfor how to use and generate test vectorsSee TBD54566975/tbdex-js#129 for how implementations can use git submodules to consume test vectors and other hosted materials.