Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/dht-create #55

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

fingersonfire
Copy link
Contributor

  • Same as old PR (hopefully) just with no changes to structure

@michaelneale
Copy link

michaelneale commented Apr 2, 2024

build failure is just due to Jwk needing to show the thumbprint as alias I think:

    final key = await keyManager.generatePrivateKey(algorithmId);

    final publicKeyJwk = await keyManager.getPublicKey(key.computeThumbprint());

This will make it work (in did_jwk.dart)

(as it isn't really returning an alias now, but the key).

Copy link

@michaelneale michaelneale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! I guess only question is if generate should return key and if so, just update docs and snippet of code to fetch the alias as mentioned.

Very cool!

packages/web5/lib/src/crypto/key_manager.dart Outdated Show resolved Hide resolved
@mistermoe
Copy link
Member

@StonePack, i just merged #56. lmk once you've rebased or merged main and i'll review. should be able to get this over the line today!

@fingersonfire
Copy link
Contributor Author

@mistermoe Should be good to go now, conflicts have been resolved

@michaelneale
Copy link

good to merge this?

Copy link
Contributor

@ethan-tbd ethan-tbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!!

@ethan-tbd ethan-tbd merged commit fe87e51 into TBD54566975:main Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants