Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of did:web to @web5/dids #263

Closed
6 tasks
nitro-neal opened this issue Nov 6, 2023 · 2 comments · Fixed by #393
Closed
6 tasks

Add implementation of did:web to @web5/dids #263

nitro-neal opened this issue Nov 6, 2023 · 2 comments · Fixed by #393
Assignees
Labels
did:web did:web package: dids @web5/dids package

Comments

@nitro-neal
Copy link
Contributor

nitro-neal commented Nov 6, 2023

Design Guidelines

  • Support for resolution of did:web DIDs by DidWebMethod implementation.
  • Test that DidWebMethod can be used with the existing DidResolver implementation.

Feature Proposal Tasks:

  • Propose API surface design prior to implementation. This can be done by creating a draft PR for a respective feature and providing prototypal code or proposing the design in the comments
  • Approval Required from a minimum of 2 people

Implementation Tasks:

  • Produce/update API reference documentation for any/all methods added to the public API surface. documenting private API methods is optional
  • Produce/update relevant example usage
  • Test coverage must be provided for all public API methods.
  • Tests that consume shared test vectors must all be passing
@frankhinek frankhinek added the did:web did:web label Nov 9, 2023
@frankhinek frankhinek changed the title Did-Web support for web5-js Add support for did:web to @web5/dids Nov 9, 2023
@frankhinek frankhinek changed the title Add support for did:web to @web5/dids Add implementation of did:web to @web5/dids Nov 9, 2023
@frankhinek frankhinek changed the title Add implementation of did:web to @web5/dids Add implementation of did:web to @web5/dids Nov 9, 2023
@mistermoe mistermoe linked a pull request Nov 10, 2023 that will close this issue
@TechWizard9999
Copy link

@nitro-neal
Could you please provide further details about this issue, such as specific implementation requirements and the location within the codebase where changes are expected? Your guidance on this matter would be greatly appreciated.

Thank you!

@frankhinek frankhinek added the package: dids @web5/dids package label Jan 5, 2024
@frankhinek frankhinek assigned frankhinek and unassigned nitro-neal Jan 16, 2024
@nitro-neal
Copy link
Contributor Author

#378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
did:web did:web package: dids @web5/dids package
Projects
Status: Done
4 participants