-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Did:Web #378
Implement Did:Web #378
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2024-01-16T22:30:22Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 91.90% 91.82% -0.08%
==========================================
Files 67 59 -8
Lines 18241 15725 -2516
Branches 1550 1294 -256
==========================================
- Hits 16764 14440 -2324
+ Misses 1454 1266 -188
+ Partials 23 19 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like accidental duplicate work. Sorry about that @nitro-neal .
Moe had put up a PR a couple of months ago that had been pulled in to the @web5/dids
refactor I have been working on for the past 7-10 days: #278
There will be a lot refactored in @web5/dids
to use the key management and other changes in @web5/crypto
so it probably doesn't make a lot of sense to merge this now and then change it a couple of days later. That being said, I think a lot of your code can replace what Moe had originally written.
Yup all good, was a good exercise regardless, I'll keep the branch open in case we need anything form it. |
yes definitely keep the branch up -- I will plan on using almost all of your code unfortunately the merge conflicts would be hellish at this point given how much has changed internally within |
This implements the did:web method to web5-js package. This also adds the did:web resolve test vectors
Example Creation:
Example did:web Document