update vc sign #332
Merged
update vc sign #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2023-12-06T17:01:20Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 92.69% 92.71% +0.01%
==========================================
Files 75 75
Lines 16786 16837 +51
Branches 1575 1577 +2
==========================================
+ Hits 15560 15610 +50
- Misses 1200 1201 +1
Partials 26 26
|
nitro-neal
commented
Dec 6, 2023
| @@ -85,6 +122,14 @@ const tbdResolver = new TbdResolver(); | |||
| export class VerifiableCredential { | |||
| constructor(public vcDataModel: VcDataModel) {} | |||
|
|
|||
| /** supported cryptographic algorithms. keys are `${alg}:${crv}`. */ | |||
| static algorithms: { [alg: string]: Signer<Web5Crypto.EcdsaOptions | Web5Crypto.EdDsaOptions> } = { | |||
There was a problem hiding this comment.
one day this will live somewhere else in a common place I'm sure
nitro-neal
commented
Dec 6, 2023
| } | ||
|
|
||
| const secp256k1Signer: Signer<Web5Crypto.EcdsaOptions> = { | ||
| signer : new EcdsaAlgorithm(), |
There was a problem hiding this comment.
yes its right my did-ion test confirms it 👍
mistermoe
approved these changes
Dec 6, 2023
frankhinek
approved these changes
Dec 6, 2023
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* update vc sign * fix spec * support signing with secp256k1 and ed25519 keys * remove unused import * add did ion test --------- Co-authored-by: Moe Jangda <moe@tbd.email>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* update vc sign * fix spec * support signing with secp256k1 and ed25519 keys * remove unused import * add did ion test --------- Co-authored-by: Moe Jangda <moe@tbd.email>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* update vc sign * fix spec * support signing with secp256k1 and ed25519 keys * remove unused import * add did ion test --------- Co-authored-by: Moe Jangda <moe@tbd.email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - #328
Updating,
vc.signto look like this: