Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@web5/agent DWN + Web5 RPC Clients #433

Merged
merged 13 commits into from
May 1, 2024
Merged

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Feb 29, 2024

In this PR:

  • organize rpc clients into agent/prototyping/clients until they have a permanent home
  • copy JsonRpcSocket class from @web5/dwn-server, using isomorphic-ws to allow for isomorphic socket client.
  • create WebSocketDwnRpcClient and WebSocketWeb5RpcClient to support web5 requests over sockets.

@LiranCohen LiranCohen changed the title DWN + Web5 Clients @web5/agent DWN + Web5 RPC Clients Feb 29, 2024
@LiranCohen LiranCohen changed the title @web5/agent DWN + Web5 RPC Clients [WIP] @web5/agent DWN + Web5 RPC Clients Feb 29, 2024
@LiranCohen LiranCohen force-pushed the lirancohen/websocket-rpc-client branch from f9c65c1 to 24a4663 Compare March 4, 2024 23:33
@frankhinek frankhinek force-pushed the agent-crypto-dids branch 3 times, most recently from 90b6048 to 5cc787a Compare March 15, 2024 21:45
@frankhinek frankhinek force-pushed the agent-crypto-dids branch 2 times, most recently from f842ffd to 2395ad4 Compare March 29, 2024 18:50
Base automatically changed from agent-crypto-dids to main March 29, 2024 19:08
@LiranCohen LiranCohen force-pushed the lirancohen/websocket-rpc-client branch from 3e67188 to 8cf351d Compare April 1, 2024 21:46
Copy link
Contributor

github-actions bot commented Apr 1, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 7

@web5/api

  • Project entry file: packages/api/src/index.ts
📄 File: ./packages/api/src/record.ts
⚠️ extractor:typedoc:missing-docs: Record.tags (GetSignature) does not have any documentation.

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts
📄 File: ./packages/crypto-aws-kms/src/ecdsa.ts
⚠️ extractor:typedoc:missing-docs: EcdsaAlgorithm (Class) does not have any documentation.
📄 File: ./packages/crypto-aws-kms/src/key-manager.ts
⚠️ extractor:typedoc:missing-docs: AwsKeyManager (Class) does not have any documentation.
📄 File: ./packages/crypto-aws-kms/src/utils.ts
⚠️ extractor:typedoc:missing-docs: getKeySpec (CallSignature) does not have any documentation.
🔀 Misc.
⚠️ extractor:typedoc:invalid-link: Failed to resolve link to "@web5/crypto#Secp256k1.adjustSignatureToLowS | here" in comment for EcdsaAlgorithm.sign. You may have wanted "@web5/crypto!Secp256k1.adjustSignatureToLowS | here"

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts
📄 File: ./packages/credentials/src/verifiable-credential.ts
⚠️ extractor:typedoc:missing-docs: CredentialSchema.__type.id (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CredentialSchema.__type.type (Property) does not have any documentation.

TBDocs Report Updated at 2024-04-30T15:21:47Z 308f325

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Merging #433 (35f19db) into main (c8e6fa8) will increase coverage by 0.24%.
Report is 2 commits behind head on main.
The diff coverage is 86.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   90.55%   90.80%   +0.24%     
==========================================
  Files         112      116       +4     
  Lines       29085    29383     +298     
  Branches     2078     2150      +72     
==========================================
+ Hits        26338    26680     +342     
+ Misses       2712     2668      -44     
  Partials       35       35              
Components Coverage Δ
agent 79.90% <86.96%> (+1.07%) ⬆️
api 97.89% <ø> (+<0.01%) ⬆️
common 98.68% <ø> (ø)
credentials 95.21% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.65% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

@LiranCohen LiranCohen force-pushed the lirancohen/websocket-rpc-client branch 3 times, most recently from a0ebcf8 to b455c28 Compare April 5, 2024 13:44
Copy link

changeset-bot bot commented Apr 5, 2024

🦋 Changeset detected

Latest commit: 308f325

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@web5/agent Patch
@web5/identity-agent Patch
@web5/proxy-agent Patch
@web5/user-agent Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LiranCohen LiranCohen force-pushed the lirancohen/websocket-rpc-client branch 4 times, most recently from 01b2d11 to 758fb8c Compare April 11, 2024 01:50
@LiranCohen LiranCohen force-pushed the lirancohen/websocket-rpc-client branch from 758fb8c to 2c50068 Compare April 11, 2024 02:33
@LiranCohen LiranCohen marked this pull request as ready for review April 11, 2024 02:41
@LiranCohen LiranCohen changed the title [WIP] @web5/agent DWN + Web5 RPC Clients @web5/agent DWN + Web5 RPC Clients Apr 11, 2024
@LiranCohen LiranCohen force-pushed the lirancohen/websocket-rpc-client branch from 08f5584 to 35f19db Compare April 24, 2024 13:26
Copy link
Contributor

@shamilovtim shamilovtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Avoiding reviewing methods that were just moved from one place to another since that's not in scope of the PR.

Only real comment is that the transportProtocols method seems possibly superfluous (are we worried someone would import HTTPWeb5RpcClient and try to use it to do something that's not HTTP?)

@LiranCohen
Copy link
Member Author

Thanks @shamilovtim!

Only real comment is that the transportProtocols method seems possibly superfluous (are we worried someone would import HTTPWeb5RpcClient and try to use it to do something that's not HTTP?)

Yeah I agree this pattern is a little weird, it was already there before the socket stuff, so I just kept it for the sake of not introducing too much change, but I feel like this should likely take on a different pattern at some point.

@LiranCohen LiranCohen merged commit ac1e6f1 into main May 1, 2024
10 checks passed
@LiranCohen LiranCohen deleted the lirancohen/websocket-rpc-client branch May 1, 2024 14:21
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants