-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@web5/agent
DWN + Web5 RPC Clients
#433
Conversation
@web5/agent
DWN + Web5 RPC Clients@web5/agent
DWN + Web5 RPC Clients
f9c65c1
to
24a4663
Compare
90b6048
to
5cc787a
Compare
f842ffd
to
2395ad4
Compare
3e67188
to
8cf351d
Compare
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-04-30T15:21:47Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 90.55% 90.80% +0.24%
==========================================
Files 112 116 +4
Lines 29085 29383 +298
Branches 2078 2150 +72
==========================================
+ Hits 26338 26680 +342
+ Misses 2712 2668 -44
Partials 35 35
|
a0ebcf8
to
b455c28
Compare
🦋 Changeset detectedLatest commit: 308f325 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
01b2d11
to
758fb8c
Compare
758fb8c
to
2c50068
Compare
@web5/agent
DWN + Web5 RPC Clients@web5/agent
DWN + Web5 RPC Clients
08f5584
to
35f19db
Compare
…vent `message` many times
35f19db
to
308f325
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Avoiding reviewing methods that were just moved from one place to another since that's not in scope of the PR.
Only real comment is that the transportProtocols method seems possibly superfluous (are we worried someone would import HTTPWeb5RpcClient and try to use it to do something that's not HTTP?)
Thanks @shamilovtim!
Yeah I agree this pattern is a little weird, it was already there before the socket stuff, so I just kept it for the sake of not introducing too much change, but I feel like this should likely take on a different pattern at some point. |
In this PR:
agent/prototyping/clients
until they have a permanent homeJsonRpcSocket
class from@web5/dwn-server
, usingisomorphic-ws
to allow for isomorphic socket client.WebSocketDwnRpcClient
andWebSocketWeb5RpcClient
to support web5 requests over sockets.