Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reference types from dwn-sdk-js to avoid pnpm build error #507

Merged
merged 3 commits into from
May 2, 2024
Merged

add reference types from dwn-sdk-js to avoid pnpm build error #507

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44ab75b
add reference types from dwn-sdk-js to avoid pnpm build error https:/…
LiranCohen May 2, 2024
6005992
add changesets
LiranCohen May 2, 2024
facd2f7
add comment and link to PR explaining why the refence type is there
LiranCohen May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/beige-tools-yawn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@web5/api": patch
---

add reference types from dwn-sdk-js to avoid pnpm build error

https://github.com/microsoft/TypeScript/issues/47663#issuecomment-1962129199
2 changes: 2 additions & 0 deletions packages/api/src/protocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/// <reference types="@tbd54566975/dwn-sdk-js" />

import type { DwnMessage, DwnResponseStatus, Web5Agent } from '@web5/agent';

import { DwnInterface } from '@web5/agent';
Expand Down
2 changes: 2 additions & 0 deletions packages/api/src/record.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/// <reference types="@tbd54566975/dwn-sdk-js" />

Check warning on line 1 in packages/api/src/record.ts

View workflow job for this annotation

GitHub Actions / tbdocs-reporter

extractor: typedoc:missing-docs 

Record.tags (GetSignature) does not have any documentation.

import type { Readable } from '@web5/common';
import type {
Web5Agent,
Expand Down
Loading