Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests for AwsKeyManager and remove skip on keymanager-aws kover-maven-plugin config #328

Open
ALRubinger opened this issue Jun 27, 2024 · 0 comments

Comments

@ALRubinger
Copy link
Contributor

ALRubinger commented Jun 27, 2024

In #322 we broke out the AwsKeyManager implementation and its test suite into its own module, web5-keymanager-aws.

This breaks the build in that new module, inheriting the coverage plugin's enforcement. Because all existing tests are marked as @Disabled, there is no coverage for the module.

To unlock the work in #322, we elected to move forward by disabling the kover-maven-plugin enforcement constraint, opting to enable the tests and re-add coverage enforcement later. That discussion is In PR #327.

This issue is the "later" cleanup task. :)

  • Enable the tests, potentially as @mistermoe suggests using localstack.
  • Remove the configuration that skips coverage enforcement in the web5-keymanager-aws pom.xml (ie. commit 1eb180c:
        <plugin>
          <groupId>io.github.martinvisser</groupId>
          <artifactId>kover-maven-plugin</artifactId>
          <configuration>
            <!-- We temporarily disable coverage enforcement until we have tests working for this module -->
            <skip>true</skip>
          </configuration>
        </plugin>
@ALRubinger ALRubinger changed the title Enable tests for AwkKeyManager and remove skip on keymanager-aws kover-maven-plugin config Enable tests for AwsKeyManager and remove skip on keymanager-aws kover-maven-plugin config Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant