generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move AwsKeyManager
into it's own module
#322
Comments
@mistermoe Just this |
@ALRubinger just |
ALRubinger
added a commit
that referenced
this issue
Jun 27, 2024
Breaks build due to insufficient test coverage and disabled tests; will need resolution. Raising in draft PR to determine how
ALRubinger
added a commit
that referenced
this issue
Jun 27, 2024
PR and open questions in #327 @mistermoe |
ALRubinger
added a commit
that referenced
this issue
Jun 27, 2024
…aws' * Revert this commit as part of #327
ALRubinger
added a commit
that referenced
this issue
Jun 27, 2024
ALRubinger
added a commit
that referenced
this issue
Jun 27, 2024
…aws' * Revert this commit as part of #327
jiyoonie9
pushed a commit
that referenced
this issue
Jun 28, 2024
jiyoonie9
pushed a commit
that referenced
this issue
Jun 28, 2024
…aws' * Revert this commit as part of #327
Closed via PR #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently,
AwsKeyManager
lives inweb5-crypto
module which happens to be the foundation of all other web5 modules.AwsKeyManager
relies onaws-java-sdk-kms
as a dependency which results inweb5-crypto
's dependency tree to look like this:we should move
AwsKeyManager
to its own module to reduce the dependency tree depth here. Further, theweb5
"rollup" shouldn't include theaws-key-manager
module. it can be pulled in if/as needed.Doing so will remove this portion of the dependency tree:
the depth here may not seem steep but the transitive deps here show up in almost every java project in one way or another and typically end up being the cause of dependency collisions
The text was updated successfully, but these errors were encountered: