Fixes issue #176. Added VerifiableCredentialJwt to support verifyAndP… #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
VerifiableCredential
Overview
Refactored
VerifiableCredential
to prevent misuse ofparseJwt()
which could cause bad actors to submit unverified JWT tokensDescription
Added
VerifiableCredentialJwt
and averifyAndParse()
function to handle the issues outlined in #176. Additionally,sign()
now returns aVerifiableCredentialJwt
instead of aString
as the only public facing mechanism to enableparseJwt()
(viaverifyAndPublish()
).How Has This Been Tested?
Existing tests have been refactored to align with these changes. New test class was created (
VerifiableCredentialJwtTest
) and new test was added to check thatverifyAndParse()
would work successfully when passed a valid token String. Negative scenarios still test the individual methods directly.