Add ability to pass in additional-properties in vc create #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w3irdrobot
requested review from
KendallWeihe,
nitro-neal,
shamilovtim,
diehuxx,
frankhinek and
leordev
as code owners
|
let's gooo |
nitro-neal
approved these changes
Oct 21, 2024
₿ cargo run -p web5_cli -- vc create did:dht:36xw3konj1pdd93axsn9p3a58a83uatcgx1nsjud97d91dtr56ry \
--issuer did:dht:36xw3konj1pdd93axsn9p3a58a83uatcgx1nsjud97d91dtr56ry \
--no-indent \
--additional-property "role:engineer" \
--additional-property "clearance:level5" \
| jq .
{
"@context": [
"https://www.w3.org/2018/credentials/v1"
],
"id": "urn:uuid:6e4bb08c-cd40-4981-ab7a-d5d7b4d8ba5d",
"type": [
"VerifiableCredential"
],
"issuer": "did:dht:36xw3konj1pdd93axsn9p3a58a83uatcgx1nsjud97d91dtr56ry",
"credentialSubject": {
"id": "did:dht:36xw3konj1pdd93axsn9p3a58a83uatcgx1nsjud97d91dtr56ry",
"role": "engineer",
"clearance": "level5"
},
"issuanceDate": "2024-10-21T23:49:57Z"
} |
|
@nitro-neal is there anything else that you need? |
|
Following up on this - @nitro-neal @KendallWeihe - is there anything else needed here to close out this PR? Given that this is the final week of Hacktoberfest, I want to make sure our contributors get their PRs accepted, and contributions count ahead of that deadline! Please review, accept and merge the task, then label it |
|
oh wait..could we resolve the merge conflicts? @w3irdrobot so that we can get this merged. |
w3irdrobot
force-pushed
the
issue-326-extra-props-vc-create
branch
from
97e8c7d
to
d51459b
Compare
|
@blackgirlbytes i cleaned it up |
w3irdrobot
force-pushed
the
issue-326-extra-props-vc-create
branch
from
d51459b
to
70d803f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds ability to pass in additional-properties in
vc create.I changed the command's method to take ownership of
selfsince it simplified my handling of the values being passed in. This change required updating of a few other parts of the code to act on the values directly instead of through references.Related Tickets & Documents
Resolves #326
Mobile & Desktop Screenshots/Recordings
Added code snippets?
Added tests?
No tests? Add a note
Added to documentation?
No docs? Add a note
[optional] Are there any post-deployment tasks we need to perform?
No
[optional] What gif best describes this PR or how it makes you feel?