-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Service Endpoints to Cli Did Web and Dht #400
Conversation
nitro-neal
commented
Oct 22, 2024
TBD Spec Test Vectors Report (web5-rs)
❌ Missing Vectors (13)These are test vectors without any test cases.
Automatically generated at: 2024-10-22T16:08:07.108Z |
TBD Spec Test Vectors Report (web5-core-kt)
❌ Missing Vectors (15)These are test vectors without any test cases.
Automatically generated at: 2024-10-22T16:12:27.396Z |
}; | ||
|
||
// Parse the domain to extract the host without the protocol | ||
let domain_host = match Url::parse(domain) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe all of this domain validation already occurs internal to the DidWeb::create()
function
let domain = &domain.to_string(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup it does, but for the service endpoint id it needs to be a valid did web uri
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"id": "did:web:www.banana.com#service-1",
"type": "PFIService",
"serviceEndpoint": [
"https://example.com"
]
}