Sync CLI options with SDK options #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
KendallWeihe,
nitro-neal,
shamilovtim,
diehuxx,
frankhinek and
leordev
as code owners
TBD Spec Test Vectors Report (web5-rs)
❌ Missing Vectors (13)These are test vectors without any test cases.
Automatically generated at: 2024-10-25T18:33:22.037Z |
nitro-neal
reviewed
Oct 24, 2024
| @@ -92,6 +121,24 @@ impl Commands { | |||
| } | |||
| }, | |||
| }; | |||
| let issuance_date = match issuance_date { | |||
There was a problem hiding this comment.
can issuance date be none?
There was a problem hiding this comment.
It cannot. Will default to current date and time.
nitro-neal
reviewed
Oct 24, 2024
| @@ -92,6 +121,24 @@ impl Commands { | |||
| } | |||
| }, | |||
| }; | |||
| let issuance_date = match issuance_date { | |||
| None => None, | |||
There was a problem hiding this comment.
Here it should do the issuance date now()?
There was a problem hiding this comment.
The SDK will take care of that. This is just meant to be a passthrough from the CLI to the SDK function.
TBD Spec Test Vectors Report (web5-core-kt)
❌ Missing Vectors (15)These are test vectors without any test cases.
Automatically generated at: 2024-10-25T18:37:46.981Z |
nitro-neal
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Also do you mind switching it to use chrono instead of System time for generating the timestamp:
There was unknown wasm black hole when using it
here was a fix in tbdex-rs - TBD54566975/tbdex-rs@6bac761
use chrono::{Duration, Utc};
use std::time::SystemTime;
let now = Utc::now();
let exp = now + Duration::seconds(60);
let now_system_time: SystemTime = now.into();
let exp_system_time: SystemTime = exp.into();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR allows the web5 cli to pass in a number of options when creating a VC.
Related Tickets & Documents
Resolves #
Mobile & Desktop Screenshots/Recordings
Added code snippets?
Added tests?
No tests? Add a note
This is simple plumbing
Added to documentation?
No docs? Add a note
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?