Introduce jose crate which is a thin wrapper around the josekit open source crate
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
commented
Apr 11, 2024
| @@ -20,3 +20,6 @@ pub trait KeyStore: Send + Sync { | |||
| private_key: Arc<dyn PrivateKey>, | |||
| ) -> Result<(), KeyStoreError>; | |||
| } | |||
|
|
|||
| // todo I don't think we should enable private keys to ever leave the KeyStore, | |||
| // so `get` doesn't make sense and `insert` should be replaced with a `generate()` method | |||
There was a problem hiding this comment.
important IMO but will be for later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
josecrate such that we don't leak abstractions, and in the event we need to swap underlying implementations, then it's contained to a single crate and not everywhereWe're using
josekitas the underlying JOSE library https://crates.io/crates/josekitI still need to update the
credentialscrate, but will do so in a subsequent PR because this one is too unweildy already