Unbound Backlight Brightness; Turn Backlight Off at 0x00 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and updated docs. Also added feature for backlight on/off to KeypadLinc, Switch, and Dimmer Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
Signed-off-by: Tom Weichmann <tommycw10@gmail.com>
Setting backlight on/off status can be controlled by setting level to 0x00 or not 0x00. Remove bounds on backlight, but update documentation to provide suggestions. Sending values outside of bounds doesn't seem to have any adverse effects, and a few devices respond outside of bounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is primarily the work of @tommycw1 from #297. This fixes #294.
This unbounds the backlight setting. As @tommycw1 points out, values below the stated value in the documentation seem to work. How low each device goes seems to vary, I have added documentation to help users. All devices seem to have an upper limit at 0x7F. But they all treat values above this as max. So I have removed the bounding as it is unnecessary.
This also merges the backlight on/off command into the level command. Setting the backlight to 0x00 will turn it off, and any other value will turn it on.
Tested on:
Dimmers
Switches
Keypadlincs
Outlets
Unit Tests Added
Linters passed.
Documentation Updated