Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDycore polymorphism, part 3: separating concerns #215

Merged
merged 75 commits into from
Dec 16, 2021
Merged

TDycore polymorphism, part 3: separating concerns #215

merged 75 commits into from
Dec 16, 2021

Commits on Oct 25, 2021

  1. Started factoring specific discretizations out of TDy. 

    This is a real mess at the moment, but it contains most of the essential
changes. Now to dig our way back to sanity.
    @jeff-cohere
    jeff-cohere committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    d764715 View commit details
    Browse the repository at this point in the history

  2. Pushing further. Things aren't getting better yet.

    @jeff-cohere
    jeff-cohere committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    45caf1d View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Factored out boundary conditions, sources/sinks, and more MPFA-O spec… 

    …ific stuff.
    @jeff-cohere
    jeff-cohere committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    16f17f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Working through MPFA-O mesh issues.

    @jeff-cohere
    jeff-cohere committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    3903318 View commit details
    Browse the repository at this point in the history

  2. Factored out TDyEOS for density/viscosity/enthalpy calculations.

    @jeff-cohere
    jeff-cohere committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    efef048 View commit details
    Browse the repository at this point in the history

  3. Adding needed parameters to impl functions. 

    Also pausing to see whether I can get rid of an irritating build system
"feature."
    @jeff-cohere
    jeff-cohere committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    ad47ed5 View commit details
    Browse the repository at this point in the history

  4. Fixing the order in which object files are compiled.

    @jeff-cohere
    jeff-cohere committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    711ddca View commit details
    Browse the repository at this point in the history

  5. Made some progress on understanding and reorganizing material models.

    @jeff-cohere
    jeff-cohere committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    eb5cee9 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Broke data out of MaterialProp type.

    @jeff-cohere
    jeff-cohere committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    a6321c5 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2021

  1. A suggested design for characteristic curves.

    @jeff-cohere
    jeff-cohere committed Oct 31, 2021
    Configuration menu
    Copy the full SHA
    dc96251 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Reimagined characteristic curves models and started prep for cleanup.

    @jeff-cohere
    jeff-cohere committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    87f6905 View commit details
    Browse the repository at this point in the history

  2. Started on the long road back. Reworked Conditions to be like Materia… 

    …lProp.
    @jeff-cohere
    jeff-cohere committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    6f944f1 View commit details
    Browse the repository at this point in the history

  3. Working through some issues with boundary conditions.

    @jeff-cohere
    jeff-cohere committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    1e5e8ed View commit details
    Browse the repository at this point in the history

  4. Documented function registry.

    @jeff-cohere
    jeff-cohere committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    ea12571 View commit details
    Browse the repository at this point in the history

  5. Repairing finite element implementations.

    @jeff-cohere
    jeff-cohere committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    e12150f View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Worked through WY compilation errors, and fixed some oversights in CC.

    @jeff-cohere
    jeff-cohere committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    0c8243d View commit details
    Browse the repository at this point in the history

  2. Worked through material property issues and remaining FE stuff. 

    Next up: MPFAO!
    @jeff-cohere
    jeff-cohere committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    ffc8079 View commit details
    Browse the repository at this point in the history

  3. Moving some things around and renaming things.

    @jeff-cohere
    jeff-cohere committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    a604ff2 View commit details
    Browse the repository at this point in the history

  4. Started on Fortran. Going to skip for now.

    @jeff-cohere
    jeff-cohere committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    0380d84 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Continuing factor-out of MPFA-O mesh.

    @jeff-cohere
    jeff-cohere committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    07a69c5 View commit details
    Browse the repository at this point in the history

  2. Consolidated MPFA-O mesh source and shook TDy out of it.

    @jeff-cohere
    jeff-cohere committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    6bf4937 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Got through most of tdympfao.c.

    @jeff-cohere
    jeff-cohere committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    c4e0f70 View commit details
    Browse the repository at this point in the history

  2. Continuing on to solver-specific stuff.

    @jeff-cohere
    jeff-cohere committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    9f311eb View commit details
    Browse the repository at this point in the history

  3. Stopping for now.

    @jeff-cohere
    jeff-cohere committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    ea16101 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. Sifting through and cleaning up some variable names.

    @jeff-cohere
    jeff-cohere committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    1cade00 View commit details
    Browse the repository at this point in the history

  2. Waded through rest of MPFA-O compile errors.

    @jeff-cohere
    jeff-cohere committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    1a722de View commit details
    Browse the repository at this point in the history

  3. Worked through some remaining issues with material props and BCs.

    @jeff-cohere
    jeff-cohere committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    305ceb1 View commit details
    Browse the repository at this point in the history

  4. Replaced porosity/permeability assignment logic in I/O system.

    @jeff-cohere
    jeff-cohere committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    21ed75c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Finished code repairs to dycore. Next up: demos!

    @jeff-cohere
    jeff-cohere committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    c29667d View commit details
    Browse the repository at this point in the history

  2. Got through most of steady demo.

    @jeff-cohere
    jeff-cohere committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    6471eff View commit details
    Browse the repository at this point in the history

  3. Worked through the rest of the compilation issues in steady.c.

    @jeff-cohere
    jeff-cohere committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    817dec9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Starting into steady demo runtime issues.

    @jeff-cohere
    jeff-cohere committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    eaa2e57 View commit details
    Browse the repository at this point in the history

  2. Disabling testing for draft PRs.

    @jeff-cohere
    jeff-cohere committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    cbfedb9 View commit details
    Browse the repository at this point in the history

  3. Disable coverage checks for draft PRs.

    @jeff-cohere
    jeff-cohere committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    4b0a111 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Fixed some glitches in tdywy. Some steady demo runs work now!

    @jeff-cohere
    jeff-cohere committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    834ba71 View commit details
    Browse the repository at this point in the history

  2. WY steady demo tests pass.

    @jeff-cohere
    jeff-cohere committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    363d1db View commit details
    Browse the repository at this point in the history

  3. All steady demo tests pass.

    @jeff-cohere
    jeff-cohere committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    dcee7d0 View commit details
    Browse the repository at this point in the history

  4. Fixed first batch of transient demos.

    @jeff-cohere
    jeff-cohere committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    08e55a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Enabling F90 module build and laying out an example.

    @jeff-cohere
    jeff-cohere committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    b6b7ab8 View commit details
    Browse the repository at this point in the history

  2. Wrapped several C functions for F90 module.

    @jeff-cohere
    jeff-cohere committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    190eb48 View commit details
    Browse the repository at this point in the history

  3. Moved F90 interface C files to f90-mod directory.

    @jeff-cohere
    jeff-cohere committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    e238b25 View commit details
    Browse the repository at this point in the history

  4. Fixed some compile warnings.

    @jeff-cohere
    jeff-cohere committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    cafc508 View commit details
    Browse the repository at this point in the history

  5. Figured out a pattern that allows us to use iso_c_binding.

    @jeff-cohere
    jeff-cohere committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    162b1a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Cleaned up the Fortran interface a bit.

    @jeff-cohere
    jeff-cohere committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    d219675 View commit details
    Browse the repository at this point in the history

  2. Reorganized mesh construction code a bit.

    @jeff-cohere
    jeff-cohere committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    1ce38ea View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Found an interopable pattern for using vectorized Fortran functions.

    @jeff-cohere
    jeff-cohere committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    f63ec85 View commit details
    Browse the repository at this point in the history

  2. Proved the Fortran function approach works, and fixed some glitches.

    @jeff-cohere
    jeff-cohere committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    01e7328 View commit details
    Browse the repository at this point in the history

  3. Fixed a small bug in TS.

    @jeff-cohere
    jeff-cohere committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    ee7220e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2021

  1. Plugged several memory leaks.

    @jeff-cohere
    jeff-cohere committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    706a42a View commit details
    Browse the repository at this point in the history

  2. Fixed a mesh geometry problem, left notes for remaining issues.

    @jeff-cohere
    jeff-cohere committed Nov 20, 2021
    Configuration menu
    Copy the full SHA
    571a37b View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Added functions for computing characteristic curves on selected point… 

    …s only.
    @jeff-cohere
    jeff-cohere committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    ffa6ed9 View commit details
    Browse the repository at this point in the history

  2. Residual saturation is now initialized during TDySetup.

    @jeff-cohere
    jeff-cohere committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    1e8fc40 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Redid Fortran function registry. 

    It's now completely separate from the C function registry, since our
vectorized spatial functions are non-interoperable.
    @jeff-cohere
    jeff-cohere committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    a1f12a8 View commit details
    Browse the repository at this point in the history

  2. Removed a print function.

    @jeff-cohere
    jeff-cohere committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    60450e0 View commit details
    Browse the repository at this point in the history

  3. Removed errant unicode character.

    @jeff-cohere
    jeff-cohere committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    dfd10fc View commit details
    Browse the repository at this point in the history

  4. Simplified characteristic curve point sets/maps.

    @jeff-cohere
    jeff-cohere committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    c277d1b View commit details
    Browse the repository at this point in the history

  5. Clarified/fixed pointwise characteristic curves functions.

    @jeff-cohere
    jeff-cohere committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    64ba272 View commit details
    Browse the repository at this point in the history

  6. Getting rid of draft PR logic--seems buggy.

    @jeff-cohere
    jeff-cohere committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    abcb890 View commit details
    Browse the repository at this point in the history

  7. Got SNES transient MPFA-O demo in shape. 

    I had to disable one test and a few diagnostics. Hope this is okay for
the purposes of this PR.
    @jeff-cohere
    jeff-cohere committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    390ac96 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Changed the name of a function.

    @jeff-cohere
    jeff-cohere committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    8e4fcfc View commit details
    Browse the repository at this point in the history

  2. Fixed indexing oversights in pointwise characteristic curve updates.

    @jeff-cohere
    jeff-cohere committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    0db6ed1 View commit details
    Browse the repository at this point in the history

  3. Fixed several bugs preventing transient_mpfaof90 tests from working.

    @jeff-cohere
    jeff-cohere committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    c745c21 View commit details
    Browse the repository at this point in the history

  4. Fixed an indexing problem in a vectorized boundary pressure func.

    @jeff-cohere
    jeff-cohere committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    a0435a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Fixed TH demo driver.

    @jeff-cohere
    jeff-cohere committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    4dd2e60 View commit details
    Browse the repository at this point in the history

  2. Fixed some issues with the Richards driver.

    @jeff-cohere
    jeff-cohere committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    59af1ca View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Fixed Richards driver tests.

    @jeff-cohere
    jeff-cohere committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    c6f4f12 View commit details
    Browse the repository at this point in the history

  2. Got rid of some unnecessary allocations.

    @jeff-cohere
    jeff-cohere committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    a0d512b View commit details
    Browse the repository at this point in the history

  3. Some minor print changes.

    @jeff-cohere
    jeff-cohere committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    a344e5e View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Commented out functions for reading/writing mesh geometry.

    @jeff-cohere
    jeff-cohere committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    5b3cce4 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Fixed some small oversights in an attempt to chase down the last TH bug.

    @jeff-cohere
    jeff-cohere committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    26fdc24 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Committing debugging environment for TH.

    @jeff-cohere
    jeff-cohere committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    7eb48a8 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. Added a new op, set_dm_fields, that sets field layouts for each model.

    @jeff-cohere
    jeff-cohere committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    8f2d046 View commit details
    Browse the repository at this point in the history

  2. Removed debugging prints.

    @jeff-cohere
    jeff-cohere committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    46a67f4 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2021

  1. Adding else clauses in reponse to PR comments.

    @jeff-cohere
    jeff-cohere committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    6216014 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'jeff-cohere/impls-refactor' of github.com:TDycores-Proj… 

    …ect/TDycore into jeff-cohere/impls-refactor
    @jeff-cohere
    jeff-cohere committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    fe06c7a View commit details
    Browse the repository at this point in the history