Feat/#30 아이콘파일 수정 #31
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "check_circular.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "checkbox_active.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "checkbox_default.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "chevron_left.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "chevron_right.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "clock.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "close.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "deletebox.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "info.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "plus.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "radiobtn_default.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "radiobtn_selected.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "return.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "search.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "sun.svg", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } | ||
|
Comment on lines
+1
to
+12
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# 설명: PR에 포함된 모든 아이콘 자산의 완전성 검증
# cherrishIcon 하위의 모든 imageset 개수 세기
icon_count=$(find . -path "*/Assets.xcassets/cherrishIcon/*.imageset" -type d 2>/dev/null | wc -l)
echo "추가된 imageset 개수: $icon_count개"
# PR 설명상 16개인지 확인
if [ "$icon_count" -eq 16 ]; then
echo "✅ 16개의 아이콘이 모두 추가되었습니다."
else
echo "⚠️ 경고: $icon_count개의 아이콘만 발견되었습니다. (예상: 16개)"
fi
# 찾은 모든 imageset 나열
echo -e "\n=== 발견된 imageset 목록 ==="
find . -path "*/Assets.xcassets/cherrishIcon/*.imageset" -type d 2>/dev/null | sort
# Contents.json과 SVG 파일의 매칭 확인
echo -e "\n=== SVG 파일과 Contents.json 매칭 검증 ==="
mismatches=0
for imageset_dir in $(find . -path "*/Assets.xcassets/cherrishIcon/*.imageset" -type d 2>/dev/null | sort); do
icon_name=$(basename "$imageset_dir" .imageset)
contents_file="$imageset_dir/Contents.json"
if [ -f "$contents_file" ]; then
# Contents.json에서 filename 추출
filename=$(grep -o '"filename"[[:space:]]*:[[:space:]]*"[^"]*"' "$contents_file" | cut -d'"' -f4)
expected_filename="${icon_name}.svg"
if [ "$filename" != "$expected_filename" ]; then
echo "❌ 불일치: $icon_name (Contents.json: $filename, 예상: $expected_filename)"
((mismatches++))
else
echo "✅ $icon_name: Contents.json filename 일치"
fi
else
echo "❌ Contents.json 누락: $icon_name"
((mismatches++))
fi
done
if [ "$mismatches" -eq 0 ]; then
echo -e "\n✅ 모든 파일명이 일치합니다."
else
echo -e "\n⚠️ $mismatches개의 불일치가 발견되었습니다."
fi
# 각 imageset 내 SVG 파일 확인
echo -e "\n=== 각 imageset 내 SVG 파일 검증 ==="
svg_mismatches=0
for imageset_dir in $(find . -path "*/Assets.xcassets/cherrishIcon/*.imageset" -type d 2>/dev/null | sort); do
icon_name=$(basename "$imageset_dir" .imageset)
expected_svg="${imageset_dir}/${icon_name}.svg"
if [ ! -f "$expected_svg" ]; then
echo "❌ SVG 파일 누락: $expected_svg"
((svg_mismatches++))
else
echo "✅ SVG 파일 존재: $icon_name"
fi
done
if [ "$svg_mismatches" -eq 0 ]; then
echo -e "\n✅ 모든 SVG 파일이 존재합니다."
else
echo -e "\n⚠️ $svg_mismatches개의 SVG 파일이 누락되었습니다."
fiRepository: TEAM-Cherrish/Cherrish-iOS Length of output: 2360 16개 아이콘 중 15개만 추가되었습니다. 누락된 아이콘 확인 필요 PR 설명에서 16개의 아이콘 자산이 추가될 예정이었으나, 현재 다음 15개만 발견되었습니다: 다행히 추가된 15개 아이콘은 모두 일관된 xcassets 메타데이터 구조를 따르고 있으며, 각 Contents.json의 filename 필드와 SVG 파일명이 정확히 일치합니다. 다만 다음을 확인하세요:
PR 설명을 업데이트하거나 누락된 아이콘을 추가해주세요. 🤖 Prompt for AI Agents |
||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
🧩 Analysis chain
🏁 Script executed:
Repository: TEAM-Cherrish/Cherrish-iOS
Length of output: 261
🏁 Script executed:
Repository: TEAM-Cherrish/Cherrish-iOS
Length of output: 310
🌐 Web query:
Xcode asset catalog "preserves-vector-representation" property SVG iOS💡 Result:
Short answer
Practical notes for SVGs in Xcode
If you want, I can show the exact Contents.json snippet or the steps in Xcode to set Scales + Preserve Vector Data.
🏁 Script executed:
Repository: TEAM-Cherrish/Cherrish-iOS
Length of output: 109
🏁 Script executed:
Repository: TEAM-Cherrish/Cherrish-iOS
Length of output: 511
🏁 Script executed:
Repository: TEAM-Cherrish/Cherrish-iOS
Length of output: 800
SVG 벡터 보존 속성 추가 권장
참조된
chevron_right.svg파일은 imageset 디렉토리에 정상적으로 존재합니다. 다만, SVG의 벡터 데이터를 보존하려면"preserves-vector-representation"속성 추가를 권장합니다. 이 속성이 없으면 Xcode가 빌드 시점에 SVG를 래스터화하여 PNG로 변환하게 됩니다.다음과 같이 수정하세요:
권장 설정
{ "images" : [ { "filename" : "chevron_right.svg", "idiom" : "universal" } ], "info" : { "author" : "xcode", "version" : 1 - } + }, + "properties" : { + "preserves-vector-representation" : true + } }📝 Committable suggestion
🤖 Prompt for AI Agents