Conversation
sum130
requested review from
soseoyo12,
wotjs020708 and
y-eonee
and removed request for
a team
Closed
1 task
📝 WalkthroughWalkthrough두 개의 UI 컴포넌트에서 레이아웃과 시각적 스타일이 변경되었습니다. CherrishNavigationBar의 패딩 방향이 수직에서 수평으로 전환되었고, SelectionChip의 배경이 조건부 색상 적용(isSelected 상태에 따라 red200 또는 gray0)이 있는 RoundedRectangle로 업데이트되었습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Global/Components/CherrishNavigationBar.swift`:
- Line 60: In CherrishNavigationBar's view modifier where you call
.padding(.horizontal, 8.adjustedH), replace the height-adjusted helper with the
width-adjusted helper by changing .adjustedH to .adjustedW so the horizontal
padding uses 8.adjustedW to match the project's horizontal sizing convention
used across components like MonthPlan and MissionCard.
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Global/Components/SelectionChip.swift`:
- Around line 21-24: Replace the use of
RoundedRectangle(...).foregroundStyle(...) with RoundedRectangle(...).fill(...)
so the background shape is colored semantically (use .fill(isSelected ? .red200
: .gray0)); also remove the extra blank space on the line containing the shape
call to match project formatting and keep the background closure compact—look
for the background modifier that constructs RoundedRectangle in SelectionChip
(uses isSelected) and update it accordingly.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
Cherrish-iOS/Cherrish-iOS/Presentation/Global/Components/CherrishNavigationBar.swiftCherrish-iOS/Cherrish-iOS/Presentation/Global/Components/SelectionChip.swift
🧰 Additional context used
🧬 Code graph analysis (1)
Cherrish-iOS/Cherrish-iOS/Presentation/Global/Components/SelectionChip.swift (1)
Cherrish-iOS/Cherrish-iOS/Presentation/Global/Extension/View+Color.swift (2)
red200(69-71)gray0(9-11)
🔇 Additional comments (1)
Cherrish-iOS/Cherrish-iOS/Presentation/Global/Components/SelectionChip.swift (1)
15-31: 선택 칩 UI 구현 적절함
isSelected상태에 따른 배경색(red200/gray0), 텍스트 색상(gray800/gray700), 테두리 색상(red500/gray500) 변경이 일관성 있게 구현되었습니다. 탭 제스처 동작도 유지되어 있습니다.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| } | ||
| .frame(height: 44.adjustedH) | ||
| .padding(.vertical, 8.adjustedH) | ||
| .padding(.horizontal, 8.adjustedH) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
rg -n "adjusted" --type swift -C3Repository: TEAM-Cherrish/Cherrish-iOS
Length of output: 30048
수평 패딩에 .adjustedH 대신 .adjustedW 사용 필요
line 60의 .padding(.horizontal, 8.adjustedH)는 프로젝트 전체에서 사용하는 패턴과 맞지 않습니다. 높이 조정용 .adjustedH 대신 너비 조정용 .adjustedW를 사용해야 합니다. MonthPlan.swift, MissionCard.swift 등 다른 컴포넌트들은 모두 .padding(.horizontal, X.adjustedW)로 일관되게 사용 중입니다.
변경 제안
-.padding(.horizontal, 8.adjustedH)
+.padding(.horizontal, 8.adjustedW)
🤖 Prompt for AI Agents
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Global/Components/CherrishNavigationBar.swift`
at line 60, In CherrishNavigationBar's view modifier where you call
.padding(.horizontal, 8.adjustedH), replace the height-adjusted helper with the
width-adjusted helper by changing .adjustedH to .adjustedW so the horizontal
padding uses 8.adjustedW to match the project's horizontal sizing convention
used across components like MonthPlan and MissionCard.
Comment on lines
+21
to
+24
| .background{ | ||
| RoundedRectangle(cornerRadius: 10) | ||
| .foregroundStyle( isSelected ? .red200 : .gray0) | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Shape에 fill() 사용 권장 및 포맷팅 개선
RoundedRectangle에 색상을 적용할 때 foregroundStyle 대신 fill()을 사용하는 것이 의미적으로 더 명확합니다. 또한 라인 23에 불필요한 공백이 있습니다.
♻️ 제안 수정
.background{
RoundedRectangle(cornerRadius: 10)
- .foregroundStyle( isSelected ? .red200 : .gray0)
+ .fill(isSelected ? .red200 : .gray0)
}🤖 Prompt for AI Agents
In `@Cherrish-iOS/Cherrish-iOS/Presentation/Global/Components/SelectionChip.swift`
around lines 21 - 24, Replace the use of
RoundedRectangle(...).foregroundStyle(...) with RoundedRectangle(...).fill(...)
so the background shape is colored semantically (use .fill(isSelected ? .red200
: .gray0)); also remove the extra blank space on the line containing the shape
call to match project formatting and keep the background closure compact—look
for the background modifier that constructs RoundedRectangle in SelectionChip
(uses isSelected) and update it accordingly.
y-eonee
approved these changes
Jan 15, 2026
Kimgyuilli
pushed a commit
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
✅ Testing
테스트 목적과 상황
시나리오 진행에 필요한 값
시나리오 진행에 필요한 조건
시나리오 완료 시 보장하는 결과
💻 주요 코드 설명
코드 설명할 파일 이름 (ex: HomeView)📚 참고자료
👀 기타 더 이야기해볼 점