Pet 100 feat : Todo 달성률 조회 API #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlarbals824
reviewed
Sep 16, 2023
|
|
||
| public Register findRecentRegisterByUserId(Long userId) { | ||
| return registerRepository.findTopByUserIdOrderByCreatedAtDesc(userId) | ||
| .orElseThrow(() -> new RegisterNotFoundException(Error.REGISTER_NOT_FOUND)); |
There was a problem hiding this comment.
이거 (() -> new NotRegisterUserException(Error.NOT_REGISTER_USER)) 로 통일할 수 있을것같은데 어떻게 생각해?
| private final CategoryQueryService categoryQueryService; | ||
|
|
||
| public TodoProgressResponse getTodoProgress(Long todoTeamId) { | ||
| if(todoTeamId == null) { |
There was a problem hiding this comment.
이렇게 null값을 받는것보다는 가입된 패밀리 id랑 이름만 반환하는 api 제공해주고
그 다음에 사용자가 선택하면 null값이 안들어올것같은데 어떻게 생각해?
tlarbals824
approved these changes
Sep 16, 2023
isprogrammingfun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업사항
변경로직
참고자료