-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copying feedback session: Name for copied session should not be whitespace #12679
Copying feedback session: Name for copied session should not be whitespace #12679
Comments
Good First Issue - Notes for Contributors Please note that we allow only one We do not assign issues to contributors. If you would like to pick up this issue, do post a comment below to express your interest and check if there is anyone else who is already working on the issue. We will do our best to reply and give you the go-ahead, but if we don't, feel free to submit a PR as long as there is no one else working on it. To get started, do read through our contributing guidelines carefully, and set up a development environment on your local machine before making a PR. If you need any clarifications on our developer guide, or are facing issues that are not found in our troubleshooting guide, please post a message in our discussion forum. |
I would like to work on this issue. Can i go ahead? |
@dhanushtheijas08 Sure thing. Feel free to submit a PR for this issue 👍🏻 |
@domlimm Hi , I am beginner, |
@rahulpro2001 Hello, please allow @dhanushtheijas08 to work on it first as he has expressed in interest. Feel free to look at other issues tagged with |
@domlimm okk |
can i work on these issue please, these is my first open source contribution ! |
Hi Could any one help me setting up project in my local system, I am getting error at build.properties as null pointer exception. Thanks |
hi @ArunErram please allow @dhanushtheijas08 to work on it first as he has expressed interest for this issue |
hi @pavanganguru, do open a help request here: https://github.com/TEAMMATES/teammates/discussions, it would be good to provide screenshots or more details about the error you're facing as well |
I see that this issue is still open, can I work on it? Also, how can I become a contributor for this repo? |
Posso contribuir com a issue ? |
Hey! is the issue resolved? If it is still open , i would like to contribute to this issue! Please let me know if I can |
@dhanushtheijas08 Hello, is there any update on this issue? Else, I will ping the next person to attempt it. Thanks! |
Hey.I still see this issue open and showing not resolved in my local.Can I take it up? |
@rahulpro2001 Please feel free to submit a PR for this if you're still interested. Else, I will pass it onto the next person. Thank you! @Afreen97 Let's go down the queue. Feel free to look at other issues tagged |
hey @domlimm, i'm also interested in working on this. please add me to the queue. |
@ArunErram @IvoHarsani @michaelviveiros Do let me know if any of you wants to take up this issue. |
@domlimm If it's available I would like it. |
@michaelviveiros Hey Michael, feel free to submit a PR for it! Thanks! |
Hello I am a beginner and would like to work on this issue. |
@ritsam Hello, lets give @michaelviveiros some time to work on this. Michael do let us know if you're not working on it anymore. @ritsam in the meantime, you may look for other good first issue to work on. |
i think, i missed the oppurtunity , do i have the chance now to work on it @domlimm ? |
hi @michaelviveiros, do let us know within 2 days if you're still working on this issue, else we'll let @ArunErram work on it |
ya @michaelviveiros update please ASAP , Thanks ! |
Hi @ArunErram, since @michaelviveiros hasn't replied, please feel free to submit a PR for this issue. Thanks for your patience! |
@weiquu sure i'm on it |
and from where can i get the test credentials to login and test the expected behaviour after making the changes? |
Hi @ArunErram, do refer to https://teammates.github.io/teammates/development.html#logging-in-to-a-teammates-instance for logging in to the local dev environment |
ok i'll work on it , thanks |
@cedricongjh after clicking on the login as instructor or student , it's not rendering to login page it's still being on the home page after loading. can you help me with these please |
i have added the validations for whitespace and the rest is to just test it |
Hi @ArunErram, please open a new topic under Discussions if you are facing any trouble that is not directly related to the current issue being fixed. In the meantime, you can also open a draft PR and tag us there if you want us to take a preliminary look |
Hi can I work on this issue as this is still open? |
@domlimm any updates please ? |
Hi, is this issue still open? If it is, can I work on it? |
Hi @sumanth-rajkumar there is currently an open PR for this #13075. In the meantime you could look at other issues to pick up. |
@domoberzin can you test and merge the above pull |
@domlimm Hello! I see that the most recent MR has been open for a while now and has failed certain test cases. I am new to this repository and would love to contribute. May I know if this issue is still open? |
Hi there, we want to sovle this issue, could I work on this? We want contribute this repo. Thank you so much! @domlimm |
Hi, we would like to contribute to this issue, is it still open? |
I would like to work on this issue. Is it possible? |
Steps to reproduce
Name for copied session*
has the same name as the Session you clicked Copy on. Now, clear the text input and this is what you will get below.Now, let's try to add a whitespace. Validation passes i.e., There is a value for the copied session's name and it is a whitespace.
Expected behaviour
Whitespace should not be allowed for the copied session's name. Input validation should not allow whitespaces.
Actual behaviour
Converse of the above expected behaviour, i.e., Currently, whitespace as name is allowed and this happens after clicking on Copy:
This is validated on the client side. However, we should validate on the form first.
Additional info
Motivation for this issue from a PR: #12670 (comment)
Proposed Solution:
src\web\app\pages-help\session-links-recovery\session-links-recovery-page.component.ts
, there is an example on how validation is done L39, and you may use the above link in Point 1 to help you too.And this is the page (http://localhost:4200/web/front/help/session-links-recovery):
To get to the above page, once you're logged in, in the navbar, click on Help -> Recover Session Links -> Hit on Submit without any input.
Let us know if you have any question.
The text was updated successfully, but these errors were encountered: