[#12679]Name for copied session should not be whitespace #13072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ArunErram, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
|
Hi @ArunErram , thanks for the PR, please (1) change the PR title to follow the guideline (2) fix the lint in the failing checks. (Click into the github action below |
ArunErram
changed the title
|
Sure I'll look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12679
Outline of Solution
Implemented validation for newFeedbackSessionName input field in the CopySessionModalComponent.ts file. The validation prevents an empty string/ whitespaces from being submitted, ensuring data integrity.
The below is the screenshot of the Expected behaviour(result) for these issue.
That Whitespace should not be allowed for the copied session's name. Input validation should not allow whitespaces.