-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#13104] Add mappings #13166
base: master
Are you sure you want to change the base?
[#13104] Add mappings #13166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions ...
Also add Malaysia and France, as often I find people typing them in ALL CAPS.
...b/app/pages-static/request-page/instructor-request-form/instructor-request-form.component.ts
Show resolved
Hide resolved
...b/app/pages-static/request-page/instructor-request-form/instructor-request-form.component.ts
Outdated
Show resolved
Hide resolved
...b/app/pages-static/request-page/instructor-request-form/instructor-request-form.component.ts
Outdated
Show resolved
Hide resolved
...b/app/pages-static/request-page/instructor-request-form/instructor-request-form.component.ts
Outdated
Show resolved
Hide resolved
...b/app/pages-static/request-page/instructor-request-form/instructor-request-form.component.ts
Outdated
Show resolved
Hide resolved
...b/app/pages-static/request-page/instructor-request-form/instructor-request-form.component.ts
Show resolved
Hide resolved
...b/app/pages-static/request-page/instructor-request-form/instructor-request-form.component.ts
Outdated
Show resolved
Hide resolved
Updated the mappings according to suggestions, marked for review. |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢 |
Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with the updates, except the one entry I've commented on.
Fixes #13104
Outline of Solution
Made the dictionary of mappings in 3f5f68d more extensive, covering more countries and cases.
Updated mappings: