Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13104] Add mappings #13166

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

itstrueitstrueitsrealitsreal
Copy link
Contributor

@itstrueitstrueitsrealitsreal itstrueitstrueitsrealitsreal commented Aug 8, 2024

Fixes #13104

Outline of Solution

Made the dictionary of mappings in 3f5f68d more extensive, covering more countries and cases.

Updated mappings:

    const countryMapping: { [key: string]: string } = {
      'united states': 'USA',
      'u.s.a': 'USA',
      'u.s.a.': 'USA',
      us: 'USA',
      america: 'USA',
      'united states of america': 'USA',

      'united kingdom': 'UK',
      uk: 'UK',
      britain: 'UK',
      'great britain': 'UK',
      england: 'UK',

      'united arab emirates': 'UAE',
      uae: 'UAE',
      emirates: 'UAE',

      deutschland: 'Germany',
      germany: 'Germany',

      netherlands: 'Netherlands',
      'the netherlands': 'Netherlands',
      nederland: 'Netherlands',
      holland: 'Netherlands',

      belgium: 'Belgium',
      belgië: 'Belgium',

      brazil: 'Brazil',
      brasil: 'Brazil',

      spain: 'Spain',
      españa: 'Spain',

      mexico: 'Mexico',
      méxico: 'Mexico',

      italy: 'Italy',
      italia: 'Italy',

      china: 'China',
      'peoples republic of china': 'China',
      prc: 'China',

      france: 'France',
      'republic of france': 'France',

      india: 'India',

      japan: 'Japan',

      russia: 'Russia',
      'russian federation': 'Russia',

      'south korea': 'South Korea',
      'republic of korea': 'South Korea',
      korea: 'South Korea',

      'north korea': 'North Korea',
      'democratic peoples republic of korea': 'North Korea',

      'south africa': 'South Africa',
      'republic of south africa': 'South Africa',

      switzerland: 'Switzerland',

      taiwan: 'Taiwan',

      turkey: 'Turkey',
      'republic of turkey': 'Turkey',
      'republic of türkiye': 'Turkey',

      vietnam: 'Vietnam',
      'viet nam': 'Vietnam',

      malaysia: 'Malaysia',
    };

Copy link
Contributor

@damithc damithc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions ...

Also add Malaysia and France, as often I find people typing them in ALL CAPS.

@itstrueitstrueitsrealitsreal
Copy link
Contributor Author

Updated the mappings according to suggestions, marked for review.

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 8 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

Copy link
Contributor

@damithc damithc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the updates, except the one entry I've commented on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accounts request form: auto-unify country names
3 participants