Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes GPU, update for clang and latest Petsc, add workflow testing build #69

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Thomas-Ulrich
Copy link
Collaborator

@Thomas-Ulrich Thomas-Ulrich commented Jun 20, 2024

(building-up on dmay/petsc_dev_hip branch)

  • fixes tandem GPU Multigrid on GPU yields different results to CPU #52 by using the allocating vector consistently with the given vec_type
  • enforce MatSetBlockSize
  • update code to compile with Clang and latest Petsc
  • add gh workflow to test compilation of tandem with gcc 13 and clang 18

@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/ghaction_compile branch 2 times, most recently from 9ad08ea to 38dced3 Compare June 20, 2024 18:09
@Thomas-Ulrich Thomas-Ulrich mentioned this pull request Jun 20, 2024
@Thomas-Ulrich Thomas-Ulrich changed the title github workflow to test compilation on PR github workflow to automatically test build and run test on pull request Jun 20, 2024
@hpc4geo hpc4geo self-assigned this Aug 29, 2024
@hpc4geo hpc4geo self-requested a review August 29, 2024 15:54
Copy link
Collaborator

@hpc4geo hpc4geo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thomas-Ulrich Where does the value of env.PETSC_VERSION come from? We will need to frequently bump the version of petsc being used over time.

@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/ghaction_compile branch 8 times, most recently from 44cdd14 to 82d2ee5 Compare September 11, 2024 07:33
@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/ghaction_compile branch from 85d086f to ddf0b8e Compare September 27, 2024 08:16
@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/ghaction_compile branch from 196c091 to 4e0ec7d Compare September 27, 2024 08:31
@Thomas-Ulrich Thomas-Ulrich changed the title github workflow to automatically test build and run test on pull request Fixes GPU, update for clang and latest Petsc, add workflow testing build Sep 27, 2024
@Thomas-Ulrich
Copy link
Collaborator Author

env.PETSC_VERSION was hardcoded. Now the code looks at the pypi server to find the latest release.
(and then we install the latest release)

@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/ghaction_compile branch from 4ed8374 to ad4a445 Compare October 16, 2024 13:02
@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/ghaction_compile branch from ad4a445 to a53dbb6 Compare October 18, 2024 11:58
@Thomas-Ulrich Thomas-Ulrich mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants