fix: 修改post请求方式 #78
Merged
fix: 修改post请求方式 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamono
added a commit
that referenced
this pull request
May 17, 2020
fix: 修改post请求方式 @b5b807747d5b1ba3b113408ee645be2a0f6eb9ba
wu-yu-xuan
reviewed
May 18, 2020
| return swr.revalidate(); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [suppress, swr.revalidate]); | ||
| export default function usePost(Request: { path: string; request: object }) { |
There was a problem hiding this comment.
我觉得使用hook去解决post问题，无异于杀鸡用牛刀，虽然也不是不行，但是觉得怪怪的，没有多大的必要性
There was a problem hiding this comment.
还有下面这什么狗屎代码，你为什么要在我的屎上再糊一层屎？
把屎删掉从头写不香吗？
There was a problem hiding this comment.
request为什么要用Pascal命名？禁止使用object/function作为类型，应该具体化，比如{}，或是（）=》void
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.