feat(gno/orgs): save & display kind of organizations #1469
Conversation
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MikaelVallenet
requested review from
n0izn0iz,
hthieu1110,
clegirar and
WaDadidou
and removed request for
n0izn0iz
gno/r/dao_realm/dao_realm.gno
Outdated
| @@ -94,7 +94,7 @@ func RegisterSelf() { | |||
| panic("already registered") | |||
| } | |||
|
|
|||
| dao_registry.Register(func() dao_interfaces.IDAOCore { return daoCore }, "DAO Realm", "Default testing DAO", "https://images.unsplash.com/photo-1477959858617-67f85cf4f1df?w=1080&fit=max") | |||
| dao_registry.Register(func() dao_interfaces.IDAOCore { return daoCore }, "DAO Realm", "Default testing DAO", "memberships based organization", "https://images.unsplash.com/photo-1477959858617-67f85cf4f1df?w=1080&fit=max") | |||
There was a problem hiding this comment.
The registry should only be mapping from realm pkgpath to IDAOCore, the additional fields were there when the profile realm didn't exist but they should be removed actually, this is a review mistake by me when we moved to profile realm for daos
I think we should handle the "dao kind" by inspecting the dao voting module, which already has a .Info() api
There was a problem hiding this comment.
So when listing (for the screens w/ all daos) should i fetch profile realm (name, bio & avatar) for each field of each DAO ?
I did what you suggest to handle the dao kind by inspecting the dao voting module using the Info().String() endpoint
There was a problem hiding this comment.
I see two option there:
- query the profile realm in the registry list function and enrich the response within gno
- use the useUserInfo hook like we do for users, it already supports gno dao if I'm not mistaken
MikaelVallenet
requested review from
n0izn0iz,
hthieu1110,
clegirar and
WaDadidou
n0izn0iz
deleted the
dev/mikaelvallenet/feat/gno-orgs-save-and-display-org-kind
branch
an organization could be based on different kinds:
This information should be saved into contracts & retrievable to be able to adapt business logic depending on the kind of the org.
The PR scope is to save it and display it in UPP
View of UPP org after PR
&&