feat(rakki): Add RAKKi to sidebar #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
force-pushed
the
feat-rakki-sidebar
branch
from
4979133 to
79eb248
Compare
WaDadidou
requested review from
n0izn0iz,
hthieu1110,
clegirar and
MikaelVallenet
and removed request for
n0izn0iz
hthieu1110
reviewed
Dec 31, 2024
| @@ -1,26 +1,33 @@ | |||
| import React from "react"; | |||
| import { StyleSheet, View, ViewStyle } from "react-native"; | |||
| import { View, ViewStyle } from "react-native"; | |||
|
|
|||
| import SideNotchSVG from "../../../../assets/sidebar/side-notch.svg"; | |||
There was a problem hiding this comment.
should we use alias import to avoid long ../ :D
There was a problem hiding this comment.
We can use @/ instead of ../../../.. yes.
I didn't change it here to limit the diffs.
It also ensure that the path is correct, no matter the number of levels in the arbo
MikaelVallenet
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding RAKKi to the sidebar
Adding notch color customization depending on the sidebar item id
teritori-dapp/packages/components/navigation/components/SideNotch.tsx
Line 10 in b82fc13
Need that to make RAKKi yellow