feat(gno/dao): GovDAO - add T3 members invitations module #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
n0izn0iz
requested changes
Feb 15, 2025
gno/r/govdao/messages.gno
Outdated
Comment on lines
89
to
91
| type AddT2MemberMessage struct { | ||
| Address string | ||
| } |
There was a problem hiding this comment.
this should be removed, the correct type is defined above
gno/r/govdao/invitations_test.gno
Outdated
Comment on lines
304
to
305
| SetProfileString: profile.SetStringField, | ||
| }) |
There was a problem hiding this comment.
Suggested change
| SetProfileString: profile.SetStringField, | |
| }) | |
| SetProfileString: profile.SetStringField, | |
| NoDefaultHandlers: true, | |
| }) |
?
Villaquiranm
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this PR: #1501
Add Delegate & Withdrawal method usable from T1, T2 & T3 members
T1 -> 3 delegation point
T2 -> 2 delegation point
T1 -> 1 delegation point
A member can only delegate one point per people
A user need 2 delegation point received to become member T3
A member already tiered T1, T2 cannot become T3 member but can still receive invitation point.
When a withdrawal removed a T3 member, all his invitations are removed meaning it can create a chain recursive effect.
Alice -> dave
Bob -> dave
Carol -> eve
Dave -> eve
if alice remove dave, he will not be a member anymore, so his invitation to eve will be removed too and eve will not be a member anymore too.
I also add limit size of 2 times T1 for T2 membership