Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Clickable "Upcoming Launches" cards #460 + updates to launchpad [👀] #463

Merged
merged 20 commits into from
Apr 4, 2023
Merged

fix: Clickable "Upcoming Launches" cards #460 + updates to launchpad [👀] #463

merged 20 commits into from
Apr 4, 2023

Conversation

omniwired
Copy link
Collaborator

@omniwired omniwired commented Feb 27, 2023 •
edited
Loading

Fixes #460

  • Order by date
  • make upcoming cards link == airtable cell link (could be evolving from Twitter link to mint page link) OR WAY BETTER create a template of mint page when the mint details are not fully confirmed yet so it's available onclick even tho the contract is not deployed yet (ie: https://magiceden.io/launchpad/the_lowlifes).
  • check the "% of mint" calculation discrepancy between the open mint page and the project card (id: T R A.I. P P E D == 6% on card & 7% on the mint page).
  • fix "ended" status for ETH mint
  • fix the "ended" status for "Teritori Name Service" by removing it from the list (leave it on the marketplace page).

Notes;

  • It needs an update in Netify to use the preview link.
  • I made the upcoming cards to point at Twitter, but not the whole new page.
  • I think we should get new designs and implement them in another PR

Screenshots Mar 2nd

image

image

@netlify
Copy link

netlify bot commented Feb 27, 2023 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 9cc5856
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/642b6f82c7bb0600089517c8
😎 Deploy Preview https://deploy-preview-463--teritori-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 27, 2023 •
edited
Loading

✅ Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 9cc5856
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/642b6f82e594440008e47cc8
😎 Deploy Preview https://deploy-preview-463--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@omniwired omniwired changed the title fix: Don't show pagination buttons if collection is less than 5 fix: Clickable "Upcoming Launches" cards #460 Feb 27, 2023
@omniwired omniwired changed the title fix: Clickable "Upcoming Launches" cards #460 fix: Clickable "Upcoming Launches" cards #460 + updates to launchpad Feb 28, 2023
@omniwired omniwired marked this pull request as ready for review March 1, 2023 05:08
@omniwired omniwired force-pushed the issue/460-clickable-upcoming-launches branch from a23dd01 to 13ebf38 Compare March 1, 2023 09:23
@omniwired omniwired marked this pull request as draft March 8, 2023 14:11
@omniwired omniwired changed the title fix: Clickable "Upcoming Launches" cards #460 + updates to launchpad fix: Clickable "Upcoming Launches" cards #460 + updates to launchpad [👷] Mar 8, 2023
@omniwired
Allow to be sorted by date
5a4df03 
General sorting improvements

Hide TNS from ended status

Speed up price look up when loading lauchpad
@omniwired omniwired added the enhancement New feature or request label Mar 10, 2023
@omniwired omniwired self-assigned this Mar 10, 2023
@omniwired omniwired marked this pull request as ready for review March 15, 2023 04:04
@omniwired omniwired requested a review from hthieu1110 March 15, 2023 04:04
@omniwired omniwired changed the title fix: Clickable "Upcoming Launches" cards #460 + updates to launchpad [👷] fix: Clickable "Upcoming Launches" cards #460 + updates to launchpad [👀] Mar 21, 2023
@omniwired omniwired requested a review from n0izn0iz March 24, 2023 09:05
@WaDadidou
Copy link
Collaborator

Are you sure about this new collections layouting ?
If yes, can you use CollectionGallery into MarketplaceScreen also ?

sakul-budhathoki
sakul-budhathoki previously approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@sakul-budhathoki sakul-budhathoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omniwired omniwired force-pushed the issue/460-clickable-upcoming-launches branch from 3dd85f0 to cfb6a9e Compare March 29, 2023 08:31
@omniwired
Copy link
Collaborator Author

Are you sure about this new collections layouting ? If yes, can you use CollectionGallery into MarketplaceScreen also ?

it will be part of another effort, not this PR

@omniwired omniwired requested a review from WaDadidou April 4, 2023 00:30
hthieu1110
hthieu1110 approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@hthieu1110 hthieu1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxxma
Copy link
Collaborator

zxxma commented Apr 4, 2023

LGTM 👍 (Finally!)

@zxxma zxxma merged commit 0afd503 into main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hthieu1110 hthieu1110 hthieu1110 approved these changes

@sakul-budhathoki sakul-budhathoki sakul-budhathoki left review comments

@n0izn0iz n0izn0iz Awaiting requested review from n0izn0iz

@WaDadidou WaDadidou Awaiting requested review from WaDadidou

Assignees

@omniwired omniwired

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clickable "Upcoming Launches" cards
5 participants
@omniwired @WaDadidou @zxxma @hthieu1110 @sakul-budhathoki