Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HtmlReporter crashes when action is missing the Desc tag #407

Closed
270899colin opened this issue Oct 15, 2024 · 1 comment · Fixed by #405
Closed

HtmlReporter crashes when action is missing the Desc tag #407

270899colin opened this issue Oct 15, 2024 · 1 comment · Fixed by #405
Assignees
@ferpasri
Labels
priority: high status: not started type: bug

Comments

@270899colin
Copy link

I am returning NOP actions from my custom protocol, this causes the HtmlReporter to throw an exception.
This is likely because there are 2 occurrences of action.get(Tags.Desc) != null where action.get throws a NoSuchTagException.
I fixed this locally by adding null as a default value: action.get(Tags.Desc, null), this causes the expressions to function as intended.
@ferpasri ferpasri self-assigned this Oct 16, 2024
ferpasri added a commit that referenced this issue Oct 18, 2024
@ferpasri
Fix reporter crash when action Desc is null #407
542c1aa 
- Update HtmlReporter and PlainTextReporter to deal with actions that do not contain the Tags.Desc
- Update NOP actions to create the 'No operation' Description by default
- Create the 'StdActionCompiler.noOperationalState' for those situations in which doing nothing in the state is a valid action
@ferpasri ferpasri linked a pull request Oct 18, 2024 that will close this issue
Add Code Coverage framework #405
Merged
3 tasks
@ferpasri ferpasri mentioned this issue Oct 18, 2024
Merged
3 tasks
@ferpasri
Copy link
Member

Thanks Colin,
This will be fixed in PR #405 when we solve a GitHub CI Actions webdriver issue we have with MacOS environments :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferpasri ferpasri

Labels
priority: high status: not started type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Code Coverage framework TESTARtool/TESTAR_dev
2 participants
@270899colin @ferpasri