Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to override CodingManager to customize the abstraction #276

Merged
merged 4 commits into from
Jul 1, 2021
Merged

Allow users to override CodingManager to customize the abstraction #276

merged 4 commits into from
Jul 1, 2021

Conversation

ferpasri
Copy link
Member

Move CodingManager building to DefaultProtocol methods

@ferpasri ferpasri requested a review from pekkakaho June 28, 2021 09:11
@odipar
Copy link
Collaborator

odipar commented Jun 28, 2021

Looks good. Wonder why you changed the CodingManager to inline the call buildIDs?

@ferpasri
Copy link
Member Author

I removed the build action method because it is not building the AbstractIDCustom and I wanted to avoid usages.
But if is more readable to have that additional method I can just make it private.

pekkakaho
pekkakaho previously approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@pekkakaho pekkakaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed, please test properly before merging

@ferpasri ferpasri requested a review from pekkakaho July 1, 2021 12:16
pekkakaho
pekkakaho previously approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@pekkakaho pekkakaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed, seems ok

@ferpasri ferpasri requested a review from pekkakaho July 1, 2021 12:32
pekkakaho
pekkakaho approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@pekkakaho pekkakaho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code reviewed

@ferpasri ferpasri merged commit 89e183a into master Jul 1, 2021
@ferpasri ferpasri deleted the refactor_coding_manager branch February 7, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekkakaho pekkakaho pekkakaho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferpasri @odipar @pekkakaho