Halting feature

[RobotoLev]

Resolves #843

---

Edited by @idinium96:

New commands (admins only) added:

• !halt - Pause the trading ⏸ (disables listings, commands, most of trades). Admins are immune. Do not spam this.
• !unhalt - Unpause the trading ▶ (enables listings, commands, trades). Do not spam this.
• !haltstatus - Get the info whether the bot is paused or not ⏯

New options added:

• offerReceived.halted.ignoreHalted
  • Default is false, if set to true, the bot will ignore all incoming offer during halt mode)
• manualReview.halted.note
  • Default is "❌ The bot is not operational right now, but your offer has been put to review, please wait for my owner to manually accept/decline your offer."
• customMessage.halted
  • Default is "❌ The bot is not operational right now. Please come back later."
• customMessage.decline.halted
  • Only triggered if you set manualReview.enable to false
  • Default is "/pre ❌ Ohh nooooes! The offer is no longer available. Reason: The offer has been declined because I am not operational right now. Please come back later."

[RobotoLev]

My tests: https://imgur.com/a/7L5kPCk
Lion is not a bot which was being tested, that's just another bot of mine. I used it to send trades since my main acc is admin.

[idinium96]

I don't think this should happen at all. GIFT summary should be the same as GIFT_NO_NOTE (no item values).

[idinium96]

But, will check again

[idinium96]

Oh what, it has a gift note, but I wonder why it passes to ONLY_METAL reason.

[idinium96]

If it's a gift, just accept (if reputation checks returned false of course).
So, yes my comment above is kinda valid.

tf2autobot/src/classes/MyHandler/MyHandler.ts

Lines 1053 to 1112 in 55aea30

	if (itemsToGiveCount === 0) {
	const isGift = [
	'gift',
	'donat', // So that 'donate' or 'donation' will also be accepted
	'tip', // All others are synonyms
	'tribute',
	'souvenir',
	'favor',
	'giveaway',
	'bonus',
	'grant',
	'bounty',
	'present',
	'contribution',
	'award',
	'nice', // Up until here actually
	'happy', // All below people might also use
	'thank',
	'goo', // For 'good', 'goodie' or anything else
	'awesome',
	'rep',
	'joy',
	'cute', // right?
	'enjoy',
	'prize',
	'free',
	'tnx',
	'ty',
	'love',
	'<3'
	].some(word => offerMessage.includes(word));
	if (isGift) {
	// We can accept escrow if it's gift
	if (checkBannedFailed) {
	offer.log('info', `is a gift offer, but failed to check for banned status, declining...`);
	return {
	action: 'decline',
	reason: 'GIFT_FAILED_CHECK_BANNED',
	meta: isContainsHighValue ? { highValue: highValueMeta } : undefined
	};
	}
	if (this.bot.isHalted) {
	offer.log('info', 'is an acceptable gift offer, but skipping due to halt mode being on');
	} else {
	offer.log(
	'trade',
	`is a gift offer, accepting. Summary:\n${JSON.stringify(
	summarize(offer, this.bot, 'summary-accepting', false),
	null,
	4
	)}`
	);
	return {
	action: 'accept',
	reason: 'GIFT',
	meta: isContainsHighValue ? { highValue: highValueMeta } : undefined
	};
	}

[idinium96]

OOOHHHHH, it was skipped. I see.
Okay, I understand now.

[idinium96]

Yeah if it's a gift, just accept, since the items are only on their side.

[idinium96]

Thank you for your hard work @RobotoLev.
My review:

[RobotoLev]

In my opinion, this can be released in v4.13. I can submit any other desirable changes after that.
If there's something that needs to be done before the first release, I can still do it, but it will take some time (I'll be busier next week).

[idinium96]

Alright, thank you very much for your help.
I will take over from here, and finalize anything that is still not done yet.

[idinium96]

Thank you 👍