Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to decline CRIME_ATTEMPT instead of counter the offer #1459

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Add an option to decline CRIME_ATTEMPT instead of counter the offer #1459

merged 4 commits into from
Jan 5, 2023

Conversation

idinium96
Copy link
Member

brysondev
brysondev approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me!

brysondev
brysondev approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, effective, clean. Looks good to me!

@brysondev brysondev self-requested a review January 5, 2023 15:48
brysondev
brysondev approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@brysondev brysondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is actually the most clean way of implementing this code, now we look good!

I swear 😤

@idinium96 idinium96 merged commit df3c2e1 into development Jan 5, 2023
@idinium96 idinium96 deleted the option-decline-crime branch January 16, 2023 22:18
@idinium96 idinium96 mentioned this pull request Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brysondev brysondev brysondev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idinium96 @brysondev @RobotoLev