fix: remove refresh token on access denied

[Nicklason]

When logging in the bot removes error listeners and only adds them back when successfully logged in. This means that if you first start the bot and get the accessdenied error, then the bot will keep crashing because it keeps trying to sign in using the invalid refresh token.

Bot registers handler for error events on the client:

tf2autobot/src/classes/Bot.ts

Line 846 in 133b3da

this.addAsyncListener(this.client, 'error', this.onError.bind(this), false);

tf2autobot/src/classes/Bot.ts

Lines 1616 to 1644 in 133b3da

	private async onError(err: CustomError): Promise<void> {
	if (err.eresult === EResult.LoggedInElsewhere) {
	log.warn('Signed in elsewhere, stopping the bot...');
	this.botManager.stop(err, false, true);
	} else if (err.eresult === EResult.AccessDenied) {
	// Access denied during login
	await this.deleteRefreshToken();
	} else if (err.eresult === EResult.LogonSessionReplaced) {
	this.sessionReplaceCount++;
	if (this.sessionReplaceCount > 0) {
	log.warn('Detected login session replace loop, stopping bot...');
	this.botManager.stop(err, false, true);
	return;
	}
	log.warn('Login session replaced, relogging...');
	await this.deleteRefreshToken();
	this.login(await this.getRefreshToken()).catch(err => {
	if (err) {
	throw err;
	}
	});
	} else {
	throw err;
	}
	}

Bot removes error listeners when attempting to log in:

tf2autobot/src/classes/Bot.ts

Lines 1389 to 1397 in 133b3da

	const listeners = this.client.listeners('error');
	this.client.removeAllListeners('error');
	const gotEvent = (): void => {
	// eslint-disable-next-line @typescript-eslint/ban-ts-comment
	// @ts-ignore
	listeners.forEach(listener => this.client.on('error', listener));
	};

Bot does not handle access denied errors in the login error handler:

tf2autobot/src/classes/Bot.ts

Lines 1408 to 1417 in 133b3da

	const errorEvent = (err): void => {
	gotEvent();
	this.client.removeListener('loggedOn', loggedOnEvent);
	clearTimeout(timeout);
	log.error('Failed to sign in to Steam: ', err);
	reject(err);
	};

[idinium96]

Thank you @Nicklason! I will look into this. Looks right already.