Ical link #116
Merged
Ical link #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 30, 2021 02:28
An ical link is now available on /calendar.ics. It contains all the ctfs with their description and dates. This endpoint is protected with a token by default, the password can be changed/removed by the admin.
|
Calendar: Admin: |
gen_random_bytes is more suited for crypto purpose
XeR
reviewed
Dec 2, 2021
| @@ -76,6 +86,7 @@ function createApp(postgraphileOptions: PostGraphileOptions) { | |||
| }) | |||
| ); | |||
| app.use(postgraphile(getDbUrl("user"), "ctfnote", postgraphileOptions)); | |||
| app.use("/calendar.ics", icalRoute(pool)); | |||
There was a problem hiding this comment.
I see the pool is only used for the ical route.
Can we use this for postgraphile too ? It would be nice to share the same connection.
| @@ -32,3 +32,5 @@ yarn-error.log* | |||
| *.njsproj | |||
| *.sln | |||
| .vscode | |||
| graphql.schema.json | |||
|
|
|||
There was a problem hiding this comment.
Since both graphql.schema.json and schema.ts are deleted, shouldn't we add both to the gitignore ?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ical link is now available on /calendar.ics.
It contains all the ctfs with their description and dates.
This endpoint is protected with a token by default,
the password can be changed/removed by the admin.