-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build errors observed with Bun #233
Conversation
Downstream I don't have any problems with building since the image I just published was created just fine: https://github.com/JJ-8/CTFNote/actions/runs/8020464483/job/21910366732 |
7426ed7
to
3dc646f
Compare
Dropped two commits that are no longer needed with v3.0.0 (thanks!). Quasar is still failing to build with bun, but now it is because of quasar using something not yet implemented in bun (not a problem on our side anymore). |
The refactoring of onResult gave a white page for me so I rewritten it to solve the error.
Hey @erdnaxe, thank you for rebasing! I tested your branch but it gave me a white page on visit. I have looked into the error and fixed it on my side. I pushed this to your branch. Can you check if it works for you too? If so, this PR can be merged. |
Hey @erdnaxe, I did not receive a response from you so I have updated your branch again with the main branch and tested it locally. It still works fine for me so I guess we can merge this. Thank you for your contribution! |
This pull requests proposes to fix multiple errors raised during a Bun build of CTFNote front. I believe most of these errors are due to an apollo version bump as bun is not using yarn.lock.
Definitely need an extra pair of eyes to check what I propose in e07b82c, I might have broken something.