Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build errors observed with Bun #233

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix build errors observed with Bun #233

merged 3 commits into from
Nov 12, 2024

Conversation

erdnaxe
Copy link
Contributor

@erdnaxe erdnaxe commented Feb 20, 2024

This pull requests proposes to fix multiple errors raised during a Bun build of CTFNote front. I believe most of these errors are due to an apollo version bump as bun is not using yarn.lock.

Definitely need an extra pair of eyes to check what I propose in e07b82c, I might have broken something.

@erdnaxe erdnaxe marked this pull request as draft February 20, 2024 20:55
@erdnaxe erdnaxe changed the title WIP: Fix bun build errors Fix build errors observed with Bun Feb 20, 2024
@erdnaxe erdnaxe marked this pull request as ready for review February 20, 2024 22:01
@XeR XeR requested a review from B-i-t-K February 20, 2024 22:11
@JJ-8
Copy link
Collaborator

JJ-8 commented Feb 23, 2024

Downstream I don't have any problems with building since the image I just published was created just fine: https://github.com/JJ-8/CTFNote/actions/runs/8020464483/job/21910366732
Maybe it is related to this commit that I don't have any issues: JJ-8@f1f070c which freezes all the dependencies and add them to git to make CTFNote 'live forever'.

@JJ-8
Copy link
Collaborator

JJ-8 commented Apr 28, 2024

Hi @erdnaxe, can you try to use v3.0.0 and see if the problem still persist? If so, can you have a look at this again?

Commit e07b82c should be merged anyway since it fixes an important deprecation notice.

@erdnaxe erdnaxe force-pushed the 0-fix-bun branch 2 times, most recently from 7426ed7 to 3dc646f Compare June 21, 2024 13:08
@erdnaxe
Copy link
Contributor Author

erdnaxe commented Jun 21, 2024

Dropped two commits that are no longer needed with v3.0.0 (thanks!).
I rebased and linted the fix for the deprecation.

Quasar is still failing to build with bun, but now it is because of quasar using something not yet implemented in bun (not a problem on our side anymore).

The refactoring of onResult gave a white page for me so I rewritten it to solve the error.
@JJ-8
Copy link
Collaborator

JJ-8 commented Jul 14, 2024

Hey @erdnaxe, thank you for rebasing! I tested your branch but it gave me a white page on visit. I have looked into the error and fixed it on my side. I pushed this to your branch. Can you check if it works for you too? If so, this PR can be merged.

@JJ-8
Copy link
Collaborator

JJ-8 commented Nov 12, 2024

Hey @erdnaxe, I did not receive a response from you so I have updated your branch again with the main branch and tested it locally. It still works fine for me so I guess we can merge this. Thank you for your contribution!

@JJ-8 JJ-8 merged commit 91a0388 into TFNS:main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants