Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the header text from NA to TFUG Jalandhar #15

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Syc0ms
Copy link

@Syc0ms Syc0ms commented Nov 25, 2024

Changed the title from NA to TFUG Jalandhar in index.html

issue #4
image

@AmanNegi
Copy link
Collaborator

@Syc0ms It's good to add preview screenshots to explain what you really did. Also not a good idea to keep the description of PR empty. (Tag the issue as well #4)

@Syc0ms
Copy link
Author

Syc0ms commented Nov 26, 2024

can you check it now?
Its my first PR in github and open-source, sorry for mistakes haha:)

@Syc0ms
Copy link
Author

Syc0ms commented Nov 26, 2024

If you have examples of PR, i would like to see it. For opening PR's in future

@AmanNegi
Copy link
Collaborator

Looks good enough for now. Regarding demo I'll link one below.

AppFlowy-IO/AppFlowy#6130

Note how they mention closes.

@AmanNegi AmanNegi merged commit 6b32609 into TFUGJalandhar:main Nov 26, 2024
@AmanNegi
Copy link
Collaborator

Thanks for the contribution.

Congratulations on your first PR. ✨🙌

@Syc0ms
Copy link
Author

Syc0ms commented Nov 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants