Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/special score #98

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Conversation

tobiichi3227
Copy link
Collaborator

In this PR, we implemented support for the special scores.
The details of the special score were written in the TFcisWiki.
We also fixed an emergency that caused a race condition in judge dispatching, which was reported by @blameazu.

Here are some minor changes included in this PR

  • Pro-rank are also ranked by score and a score column has been added
  • Add a new status: SJE(Special Judge Error) to help admin better identify errors
  • Add a warning label on the problem update page to inform admin that only problem-package(.tar.xz) can be uploaded
  • Enhance robustness in parsing problem package config
  • Clean up unused code in services/pro.py

In this [commit](d466616aca), NTOJ-Judge supports checker overwriting the score and state.
Therefore, we need to update our backend to support this feature.
In this PR, we add support for special score styles in CMS (groupmin).
We can precisely control the score in each subtask.
Multiply the subtask score by a decimal between 0 and 1.
@LifeAdventurer
Copy link
Collaborator

In conclusion, you've done a great job with the pull request description! It's clear, detailed, and well-structured, making it much easier to understand the context and changes. Keep up the good work!

@tobiichi3227 tobiichi3227 removed the request for review from blameazu October 23, 2024 11:01
Copy link
Collaborator

@LifeAdventurer LifeAdventurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing the URL to which the test sends requests to a constant.

@tobiichi3227
Copy link
Collaborator Author

ok

@tobiichi3227 tobiichi3227 force-pushed the feat/special-score branch 4 times, most recently from b146d85 to 7445fb5 Compare October 23, 2024 13:26
@tobiichi3227
Copy link
Collaborator Author

@LifeAdventurer

@LifeAdventurer LifeAdventurer merged commit 2b74d3d into TFcis:v2.0 Oct 24, 2024
@tobiichi3227 tobiichi3227 deleted the feat/special-score branch December 15, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants