-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If plugins are Installed, it runs the installer again #496
Comments
Thank you for reporting. |
@jrfnl Or the option of install should not be there. |
It is only included in the 'bulk' list, not underneath the plugin if the plugin is already installed.
I understand your desire for this, however, TGMPA uses one page to display required and recommended plugins from both plugins as well as theme(s). So if all of these would overrule the dashboard link to there own page, we'd get a 'battle of priorities' which - to me - does not seem very useful. |
@jrfnl Here's why I want this. |
I understand, but another theme or plugin which the user has installed might want to do the same which is what I meant with a 'battle of priorities'.... |
@jrfnl Got your point. But TGMPA is a pretty small library, would it be wrong if I get to configure it just for my theme or plugin? If you allow such configurations, then we could have a config file to change things like these and use the library without any conflicts. |
Actually it is used by thousands of themes and plugins, so chances of conflicts are a lot higher than you might think. |
@jrfnl I know it is being used by a lot of themes and plugins, by pretty small I meant by number of files. I care a lot about user experience that is why I said that. Little knowledge that I have about the class Thomas wrote, can you tell me what could be a confilict if I change the name of the class |
@ahmadawais Just renaming the main class will not work. Also, if you go through the whole file and adjust everything what would need adjusting to properly create an isolated fork, you would IMHO create a deteriorated user experience as now the user will end up with two notices at the top of admin pages and two different pages to install plugins if another plugin/theme also uses TGMPA. |
Got it! |
Consider I have two plugins required which are already installed but not activated. Instead of
activating
them a user can seletect them all and selectinstall
and apply. Which leads toThis must not be possible, it should skip the install and just activate them.
The text was updated successfully, but these errors were encountered: