Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Your first $this->string init before init action running. #177

Closed
wants to merge 1 commit into from
Closed

Your first $this->string init before init action running. #177

wants to merge 1 commit into from

Conversation

KingYes
Copy link
Contributor

@KingYes KingYes commented Mar 24, 2014

Hey @thomasgriffin

You are need to wrap this method after init action running cuz load the current textdomain.

Best,
Yakir

@KingYes KingYes mentioned this pull request Mar 24, 2014
Closed
@KingYes
Copy link
Contributor Author

KingYes commented Mar 28, 2014

Hey @thomasgriffin, what you think about my code?

@thomasgriffin
Copy link
Contributor

I'm not sure I understand the reason why you want to move this. Is it because translations will load too late?

@KingYes
Copy link
Contributor Author

KingYes commented Mar 29, 2014

Yes !

@thomasgriffin
Copy link
Contributor

I have fixed this manually since your indenting was a little off. Thanks for your request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KingYes @thomasgriffin