Update Feature (was Develop) #351
Conversation
The initial attempt is still crude hack to add plugin updating ability to the bulk table form. Needs more work to add better messages for updating and things such as putting to maintenance mode first, implements the Plugin_Upgrader class actions and filters. Need more testing if this will work on every possible servers.
Added plugin version check when attempted to force activate a plugin, only activate if the version is higher than the registry.
fix esc url causing broken link, need testing!
merging develop with mainstream
…ivation Conflicts: class-tgm-plugin-activation.php
|
Hi guys, is this going to be implemented anytime soon? Thanks |
|
@jrfnl has looked through the code, but found several issues with it:
So, yes, while this feature will probably get into the 2.5.0 release, it needs implementing properly in a way that we'd be happy. This ticket will be closed once the new PR has been created. |
|
ok thanks for the info, and I think at this rate its better if you develop your own version on how to update this plugin. it is a nightmare to keep up with the mainstream repo |
|
@duckzland I'm working on integrating your code and have just send in #368 to actually make integrating the update feature a lot simpler - with graceful thanks for all the hard work you've done on this! |
|
@jrfnl If possible you could take a look at my master branch, I've clean out a bit the code and now the updating and install will have 2 different set of page, each page will list only plugin related to be updated and / or installed. I really believe at this development pace, it is better if the collaborator to do the integration, will result in much cleaner code imo. |
|
@duckzland I will - I've got your fork as one of the remotes for my local version atm ;-) |
|
@duckzland - so is there any help needed any more, or now we just wait? |
|
Just wait :-) #368 is going in shortly, followed by some abstraction-related PRs to reduce duplicate code, then we have a cleaner code base to add new features like updates :-) |
|
@swiderski I think just as gary said, better wait till the chaos finish and we can try to test and sort out bugs :) |
|
@duckzland @swiderski With a bit of luck, I'll have something for you to test some time tomorrow. Fingers crossed. |
@duckzland Where can I find that code ? I've done compares based on Duckzland-update-branch/add_update_mode and on https://github.com/duckzland/TGM-Plugin-Activation/commit/abc28dbcfb04bb8fc1fdc53c11c00ef6750aa5de which is the last usable one I can do a compare on. |
|
@jrfnl it is in the master branch the add_update_mode is based on the 2.4.x branch while the master branch is based on the 2.5.x branch. You can use PHPStorm IDE with compare with clipboard function it should easen the comparison. |
|
@duckzland Will have a look, but seriously - why make it so difficult ? |
|
@jrfnl sorry wasnt intended to make things difficult for you. |
|
@duckzland not just me, you're going to have a hell of a job if you ever want to be able to pull the changes from this plugin into your fork again. |
|
@jrfnl oh this fork is temporary fix only since I got themes that need to be released asap, once you got this feature in mainstream I'm going to remove the fork :) no need for forking if mainstream has it. |
|
IF you like I can make some merge and switching back to proper Wordpress coding style. It wont take more then 10 minutes with PHPStorm. Just tell me what you need exactly. |
|
@swiderski its cool by me :) maybe create a new branch based on master? or you can coordinate with jrfnl for whatever best for her :) |
|
@swiderski Don't bother. I'm implementing that bit quite differently anyhow. |
|
A version has been merged into the |
Update feature!
Hopefully this time I will do it right.