Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the nag style on wide screens #495

Closed
wants to merge 1 commit into from
Closed

Fix the nag style on wide screens #495

wants to merge 1 commit into from

Conversation

primozcigler
Copy link

@primozcigler
Copy link
Author

I see #478 is related, but the actual implementation there appears to be wrong to me.

jrfnl added a commit that referenced this pull request Jan 5, 2016
@jrfnl
Fix admin notice class.
5b057f5 
Semi-consistent display of the admin notice.

Fixes #478, #495. Props @Ninos

Work around all the changes to the various admin notice classes between WP 4.4 and 3.7 (lowest WP version currently supported by TGMPA).
@jrfnl jrfnl mentioned this pull request Jan 5, 2016
Merged
@jrfnl
Copy link
Contributor

jrfnl commented Jan 5, 2016

Hi @primozcigler I finally had time to properly test this and ended up with a slightly different implementation #509 for consistency. Thank you for bringing this to our attention and I look forward to your next pull request.

@jrfnl jrfnl closed this Jan 5, 2016
@primozcigler
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Admin Notices
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@primozcigler @jrfnl