Add loading of TGMPA native translation files. #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/add-tgmpa-native-translations
branch
3 times, most recently
from
ddcfeec
to
70da410
Compare
|
Added one extra bit of lean loading code: https://github.com/TGMPA/TGM-Plugin-Activation/pull/521/files#diff-6f3dff769e44625dd72b031675006eb3R455 just in case & adjusted the regex in the generator to match. |
jrfnl
added a commit
that referenced
this pull request
Jan 10, 2016
Implemented in a way that the language loading will work independently of whether TGMPA is included in a plugin or a theme. Including compatibility for looking in both the WP_LANG_DIR/plugins/ as well as the WP_LANG_DIR/themes/ directory for translations served by Wp.org. Ignore warnings from PHPCS as we *really* should suppress warning on `is_readable()`.
|
Squashed the commits into one. |
jrfnl
force-pushed
the
feature/add-tgmpa-native-translations
branch
from
63960ab
to
48fdf58
Compare
GaryJones
added a commit
that referenced
this pull request
Jan 23, 2016
Add loading of TGMPA native translation files.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented in a way that the language loading will work independently of whether TGMPA is included in a (must-use) plugin or a parent/child theme.
Includes compatibility for looking in both the WP_LANG_DIR/plugins/ as well as the WP_LANG_DIR/themes/ directory for translations served by wp.org.
I was hesitant to add this code when I wrote it initially some months ago, but now with the Custom TGMPA Generator, that's no longer an issue.
The PR for the Generator #519 already includes the necessary code to remove the code from this PR from TGMPA for wp.org hosted themes.