Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devcontainer fixes #136

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Devcontainer fixes #136

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8165a3
Pin cpplint to version 1.6.1
BrianMichell Oct 22, 2024
a8a5598
Fix Dockerfile: Remove unnecessary environment variable and update pip
BrianMichell Oct 22, 2024
9649c18
Merge branch 'main' into 135_devcontainer_updates
BrianMichell Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@ ARG POETRY_VERSION=1.2.2
ARG CMAKE_MAJOR=3.24
ARG CMAKE_VERSION=3.24.2
ARG HYPERFINE=1.15.0

# avoid a torch.distributed error
# TODO: figure out optimal value
ENV OMP_NUM_THREADS=1
ARG CPPLINT_VERSION=1.6.1

# C++/build dependencies
RUN apt update \
Expand Down Expand Up @@ -63,10 +60,7 @@ RUN mkdir -p /venv
RUN python3.10 -m venv /venv
ENV PATH="/venv/bin:$PATH"

# FIXME - pip is out of date, find a better way
RUN pip install --upgrade pip

RUN pip install wheel yapf cpplint zarr xarray
RUN pip install wheel yapf cpplint==${CPPLINT_VERSION} zarr xarray

RUN pip install \
"poetry==$POETRY_VERSION" \
Expand Down
Loading