Allow import/export completely custom SEG-Y via spec override environment variable #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded segy from version 0.2.0 to 0.2.2 in pyproject.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some edge cases (i.e. custom header definitions out of spec) when default MDIO SEG-Y spec doesn't unpack some values into JSON and if it is exported, the data will be lost.
In those cases we can give a full SEG-Y spec based on the
TGSAI/segyschema as a JSON environment variable:MDIO__SEGY__SPEC.As long as the user has the JSON available at runtime; MDIO should be able to ingest/export files conforming to that spec.
IMPORTANT: Re-emphasizing that the files ingested with a custom JSON spec will ONLY be exportable if the spec is available. Or else default MDIO can't export it since it will be out of spec.