Merge pull request #245 from THEOplayer/bugfix/newarch_podspec_old

Bugfix/newarch podspec old
THEOplayer · Jan 10, 2025 · 6d5f349 · 6d5f349
2 parents 7c265dc + f8559a1
commit 6d5f349
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 11 deletions.
diff --git a/.changeset/eighty-waves-rescue.md b/.changeset/eighty-waves-rescue.md
@@ -0,0 +1,10 @@
+---
+'@theoplayer/react-native-analytics-comscore': patch
+'@theoplayer/react-native-analytics-conviva': patch
+'@theoplayer/react-native-analytics-nielsen': patch
+'@theoplayer/react-native-yospace': patch
+'@theoplayer/react-native-analytics-youbora': patch
+'@theoplayer/react-native-analytics-mux': patch
+---
+
+Fixed an issue on iOS where the podspec files did not contain all references when not using the New Architecture.
diff --git a/comscore/react-native-theoplayer-comscore.podspec b/comscore/react-native-theoplayer-comscore.podspec
@@ -16,14 +16,15 @@ Pod::Spec.new do |s|
 
   s.source_files = "ios/**/*.{h,m,mm,swift}"
 
+  s.dependency "react-native-theoplayer"
+  s.dependency "THEOplayer-Connector-Comscore", "~> 8.0"
+
   # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
   # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
   if respond_to?(:install_modules_dependencies, true)
     install_modules_dependencies(s)
   else
     s.dependency "React-Core"
-    s.dependency "react-native-theoplayer"
-    s.dependency "THEOplayer-Connector-Comscore", "~> 8.0"
 
     # Don't install the dependencies when we run `pod install` in the old architecture.
     if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then

diff --git a/conviva/react-native-theoplayer-conviva.podspec b/conviva/react-native-theoplayer-conviva.podspec
@@ -16,14 +16,15 @@ Pod::Spec.new do |s|
 
   s.source_files = "ios/**/*.{h,m,mm,swift}"
 
+  s.dependency "react-native-theoplayer"
+  s.dependency "THEOplayer-Connector-Conviva", "~> 8.0"
+
   # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
   # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
   if respond_to?(:install_modules_dependencies, true)
     install_modules_dependencies(s)
   else
     s.dependency "React-Core"
-    s.dependency "react-native-theoplayer"
-    s.dependency "THEOplayer-Connector-Conviva", "~> 8.0"
 
     # Don't install the dependencies when we run `pod install` in the old architecture.
     if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then

diff --git a/mux/react-native-theoplayer-mux.podspec b/mux/react-native-theoplayer-mux.podspec
@@ -16,14 +16,15 @@ Pod::Spec.new do |s|
 
   s.source_files = "ios/**/*.{h,m,mm,swift}"
 
+  s.dependency "react-native-theoplayer"
+  s.dependency "Mux-Stats-THEOplayer", "~> 0.11"
+
   # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
   # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
   if respond_to?(:install_modules_dependencies, true)
     install_modules_dependencies(s)
   else
     s.dependency "React-Core"
-    s.dependency "react-native-theoplayer"
-    s.dependency "Mux-Stats-THEOplayer", "~> 0.11"
 
     # Don't install the dependencies when we run `pod install` in the old architecture.
     if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then

diff --git a/nielsen/react-native-theoplayer-nielsen.podspec b/nielsen/react-native-theoplayer-nielsen.podspec
@@ -16,14 +16,15 @@ Pod::Spec.new do |s|
 
   s.source_files = "ios/**/*.{h,m,mm,swift}"
 
+  s.dependency "react-native-theoplayer"
+  s.dependency "THEOplayer-Connector-Nielsen", "~> 8.0"
+
   # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
   # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
   if respond_to?(:install_modules_dependencies, true)
     install_modules_dependencies(s)
   else
     s.dependency "React-Core"
-    s.dependency "react-native-theoplayer"
-    s.dependency "THEOplayer-Connector-Nielsen", "~> 8.0"
 
     # Don't install the dependencies when we run `pod install` in the old architecture.
     if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then

diff --git a/yospace/react-native-theoplayer-yospace.podspec b/yospace/react-native-theoplayer-yospace.podspec
@@ -16,13 +16,14 @@ Pod::Spec.new do |s|
 
   s.source_files = "ios/**/*.{h,m,mm,swift}"
 
+  s.dependency "react-native-theoplayer"
+
   # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
   # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
   if respond_to?(:install_modules_dependencies, true)
     install_modules_dependencies(s)
   else
     s.dependency "React-Core"
-    s.dependency "react-native-theoplayer"
 
     # Don't install the dependencies when we run `pod install` in the old architecture.
     if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then

diff --git a/youbora/react-native-theoplayer-youbora.podspec b/youbora/react-native-theoplayer-youbora.podspec
@@ -16,14 +16,15 @@ Pod::Spec.new do |s|
 
   s.source_files = "ios/**/*.{h,m,mm,swift}"
 
+  s.dependency "react-native-theoplayer"
+  s.dependency "YouboraTHEOPlayerAdapter"
+
   # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
   # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
   if respond_to?(:install_modules_dependencies, true)
     install_modules_dependencies(s)
   else
     s.dependency "React-Core"
-    s.dependency "react-native-theoplayer"
-    s.dependency "YouboraTHEOPlayerAdapter"
 
     # Don't install the dependencies when we run `pod install` in the old architecture.
     if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then