Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a checkpoint loading issue by adding a defensive check in the Megatron optimizer patch to prevent KeyError when accessing the "step" key in parameter groups. The version is also bumped to reflect the nightly build.
- Added defensive check for "step" key existence before accessing it in parameter groups
- Updated nightly development version
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker/version.txt | Bumps nightly development version from 20251209d to 20251212a |
| docker/patch/latest/megatron.patch | Adds safety check to verify "step" key exists in param_group before accessing it, preventing potential KeyError during checkpoint loading |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Birch-san
added a commit
to NovelAI/Megatron-LM
that referenced
this pull request
Dec 12, 2025
…HUDM/slime#1095 "fix_load_ckpt". This is an ad hoc patch for megatron. The origin issue is that megatron will assign step = None for the gpu optimizer in the hybrid optimizer which slime used as the pure cpu optimizer. In slime we won't use the gpu optimizer in most of the time, so this patch only fix the ckpt loading part.
Fengzdadi
pushed a commit
to Fengzdadi/slime
that referenced
this pull request
Dec 19, 2025
fix_load_ckpt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.